* [PATCH] net/mlx5: Remove the repeated declaration
@ 2021-12-07 12:35 Shaokun Zhang
2021-12-07 12:40 ` Leon Romanovsky
2021-12-13 18:29 ` Saeed Mahameed
0 siblings, 2 replies; 6+ messages in thread
From: Shaokun Zhang @ 2021-12-07 12:35 UTC (permalink / raw)
To: netdev, linux-rdma
Cc: Shaokun Zhang, Saeed Mahameed, Leon Romanovsky, David S. Miller,
Jakub Kicinski
Function 'mlx5_esw_vport_match_metadata_supported' and
'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
the repeated declaration and blank line.
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
index 42f8ee2e5d9f..844e673ff73c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
@@ -339,9 +339,6 @@ void mlx5_esw_match_metadata_free(struct mlx5_eswitch *esw, u32 metadata);
int mlx5_esw_qos_modify_vport_rate(struct mlx5_eswitch *esw, u16 vport_num, u32 rate_mbps);
-bool mlx5_esw_vport_match_metadata_supported(const struct mlx5_eswitch *esw);
-int mlx5_esw_offloads_vport_metadata_set(struct mlx5_eswitch *esw, bool enable);
-
/* E-Switch API */
int mlx5_eswitch_init(struct mlx5_core_dev *dev);
void mlx5_eswitch_cleanup(struct mlx5_eswitch *esw);
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5: Remove the repeated declaration
2021-12-07 12:35 [PATCH] net/mlx5: Remove the repeated declaration Shaokun Zhang
@ 2021-12-07 12:40 ` Leon Romanovsky
2021-12-08 1:27 ` Shaokun Zhang
2021-12-13 18:29 ` Saeed Mahameed
1 sibling, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2021-12-07 12:40 UTC (permalink / raw)
To: Shaokun Zhang
Cc: netdev, linux-rdma, Saeed Mahameed, David S. Miller,
Jakub Kicinski
On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
> Function 'mlx5_esw_vport_match_metadata_supported' and
> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> the repeated declaration and blank line.
>
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
> 1 file changed, 3 deletions(-)
>
Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/mlx5: Remove the repeated declaration
2021-12-07 12:40 ` Leon Romanovsky
@ 2021-12-08 1:27 ` Shaokun Zhang
2021-12-08 8:59 ` Leon Romanovsky
0 siblings, 1 reply; 6+ messages in thread
From: Shaokun Zhang @ 2021-12-08 1:27 UTC (permalink / raw)
To: Leon Romanovsky
Cc: netdev, linux-rdma, Saeed Mahameed, David S. Miller,
Jakub Kicinski
Hi Leon,
On 2021/12/7 20:40, Leon Romanovsky wrote:
> On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
>> Function 'mlx5_esw_vport_match_metadata_supported' and
>> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
>> the repeated declaration and blank line.
>>
>> Cc: Saeed Mahameed <saeedm@nvidia.com>
>> Cc: Leon Romanovsky <leon@kernel.org>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>
> Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
>
Shall we need this tag since it is trivial cleanup patch?
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Thanks your reply.
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/mlx5: Remove the repeated declaration
2021-12-08 1:27 ` Shaokun Zhang
@ 2021-12-08 8:59 ` Leon Romanovsky
2021-12-08 15:08 ` Jakub Kicinski
0 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2021-12-08 8:59 UTC (permalink / raw)
To: Shaokun Zhang
Cc: netdev, linux-rdma, Saeed Mahameed, David S. Miller,
Jakub Kicinski
On Wed, Dec 08, 2021 at 09:27:37AM +0800, Shaokun Zhang wrote:
> Hi Leon,
>
> On 2021/12/7 20:40, Leon Romanovsky wrote:
> > On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
> >> Function 'mlx5_esw_vport_match_metadata_supported' and
> >> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> >> the repeated declaration and blank line.
> >>
> >> Cc: Saeed Mahameed <saeedm@nvidia.com>
> >> Cc: Leon Romanovsky <leon@kernel.org>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> Cc: Jakub Kicinski <kuba@kernel.org>
> >> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> >> ---
> >> drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
> >> 1 file changed, 3 deletions(-)
> >>
> >
> > Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
> >
>
> Shall we need this tag since it is trivial cleanup patch?
I don't know about netdev policy about Fixes line.
IMHO, it should be always when the bug is fixed.
Thansk
>
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
>
> Thanks your reply.
>
> > .
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/mlx5: Remove the repeated declaration
2021-12-08 8:59 ` Leon Romanovsky
@ 2021-12-08 15:08 ` Jakub Kicinski
0 siblings, 0 replies; 6+ messages in thread
From: Jakub Kicinski @ 2021-12-08 15:08 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Shaokun Zhang, netdev, linux-rdma, Saeed Mahameed,
David S. Miller
On Wed, 8 Dec 2021 10:59:45 +0200 Leon Romanovsky wrote:
> > > Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
> >
> > Shall we need this tag since it is trivial cleanup patch?
>
> I don't know about netdev policy about Fixes line.
>
> IMHO, it should be always when the bug is fixed.
This is not a bug, tho. Bugs bother users.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5: Remove the repeated declaration
2021-12-07 12:35 [PATCH] net/mlx5: Remove the repeated declaration Shaokun Zhang
2021-12-07 12:40 ` Leon Romanovsky
@ 2021-12-13 18:29 ` Saeed Mahameed
1 sibling, 0 replies; 6+ messages in thread
From: Saeed Mahameed @ 2021-12-13 18:29 UTC (permalink / raw)
To: zhangshaokun@hisilicon.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, leon@kernel.org
On Tue, 2021-12-07 at 20:35 +0800, Shaokun Zhang wrote:
> Function 'mlx5_esw_vport_match_metadata_supported' and
> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> the repeated declaration and blank line.
>
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Applied to net-next-mlx5.
Thanks !
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-13 18:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-07 12:35 [PATCH] net/mlx5: Remove the repeated declaration Shaokun Zhang
2021-12-07 12:40 ` Leon Romanovsky
2021-12-08 1:27 ` Shaokun Zhang
2021-12-08 8:59 ` Leon Romanovsky
2021-12-08 15:08 ` Jakub Kicinski
2021-12-13 18:29 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).