From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Martyn Welch <martyn.welch@collabora.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC net] net: dsa: mv88e6xxx: allow use of PHYs on CPU and DSA ports
Date: Tue, 7 Dec 2021 12:58:21 +0000 [thread overview]
Message-ID: <Ya9abXJELHCaBE0k@shell.armlinux.org.uk> (raw)
In-Reply-To: <aa5e48e4b03eb9fd8eb6dacb439ef8e600245774.camel@collabora.com>
On Tue, Dec 07, 2021 at 12:47:35PM +0000, Martyn Welch wrote:
> Sorry Russell, but unfortunately this patch doesn't seem to be
> resolving the issue for me.
>
> I've dumped in a bit of debug around this change to see if I could
> determine what was going on here, it seems that in my case the function
> is being exited before this at:
>
> /* FIXME: is this the correct test? If we're in fixed mode on an
> * internal port, why should we process this any different from
> * PHY mode? On the other hand, the port may be automedia between
> * an internal PHY and the serdes...
> */
> if ((mode == MLO_AN_PHY) && mv88e6xxx_phy_is_internal(ds, port))
> return;
Oh, I was going to remove that, but clearly forgot, sorry. Please can
you try again with that removed? Meanwhile, I'll update the patch at
my end.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-12-07 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 10:59 [PATCH RFC net] net: dsa: mv88e6xxx: allow use of PHYs on CPU and DSA ports Russell King (Oracle)
2021-12-07 12:47 ` Martyn Welch
2021-12-07 12:58 ` Russell King (Oracle) [this message]
2021-12-07 14:20 ` Martyn Welch
2021-12-07 14:23 ` Russell King (Oracle)
2021-12-07 14:54 ` Andrew Lunn
2021-12-07 14:58 ` Russell King (Oracle)
2021-12-07 15:07 ` Andrew Lunn
2021-12-07 15:28 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9abXJELHCaBE0k@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=martyn.welch@collabora.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).