From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maarten Zanders <maarten.zanders@mind.be>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: fix "don't use PHY_DETECT on internal PHY's"
Date: Tue, 7 Dec 2021 13:24:13 +0000 [thread overview]
Message-ID: <Ya9gfZdbcfn11IsG@shell.armlinux.org.uk> (raw)
In-Reply-To: <f68a2913-779b-65b7-0dac-27a2c4521c42@mind.be>
On Tue, Dec 07, 2021 at 02:22:56PM +0100, Maarten Zanders wrote:
> On 12/7/21 11:32, Russell King (Oracle) wrote:
> > Maarten Zanders has confirmed that the issue he was addressing was for
> > an 88E6250 switch, which does not have a PHY_DETECT bit in bit 12, but
> > instead a link status bit. Therefore, mv88e6xxx_port_ppu_updates() does
> > not report correctly.
> ...> Yes, you're right, I'm targeting the 6250 family. And yes, your
> > suggestion would solve my case and is a better implementation for
> > the other devices (as far as I can see).
>
> I confirm that this patch works on my hardware, which uses an 88E6071
> (88E6250 family).
Thanks for testing! Would you be able to supply a Tested-by:
attributation for the patch, so your confirmation can be recorded in
the commit please?
Thanks again.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-12-07 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 10:32 [PATCH net] net: dsa: mv88e6xxx: fix "don't use PHY_DETECT on internal PHY's" Russell King (Oracle)
2021-12-07 13:22 ` Maarten Zanders
2021-12-07 13:24 ` Russell King (Oracle) [this message]
2021-12-07 13:41 ` Maarten Zanders
2021-12-08 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9gfZdbcfn11IsG@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=maarten.zanders@mind.be \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).