From: Tony Lu <tonylu@linux.alibaba.com>
To: Karsten Graul <kgraul@linux.ibm.com>
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v2] net/smc: Don't call clcsock shutdown twice when smc shutdown
Date: Fri, 26 Nov 2021 10:36:01 +0800 [thread overview]
Message-ID: <YaBIEUO0eOUNqf0b@TonyMac-Alibaba> (raw)
In-Reply-To: <1a7b27ec-22fc-f1b0-6b7c-4a61c072ff38@linux.ibm.com>
On Thu, Nov 25, 2021 at 03:51:06PM +0100, Karsten Graul wrote:
> On 25/11/2021 14:24, Tony Lu wrote:
> > @@ -2398,7 +2400,12 @@ static int smc_shutdown(struct socket *sock, int how)
> > }
> > switch (how) {
> > case SHUT_RDWR: /* shutdown in both directions */
> > + old_state = sk->sk_state;
> > rc = smc_close_active(smc);
> > + if (old_state == SMC_ACTIVE &&
> > + sk->sk_state == SMC_PEERCLOSEWAIT1)
> > + do_shutdown = false;
> > +
> > break;
>
> Please send a v3 without the extra empty line before the break statement,
> and then the patch is fine with me.
>
> Thank you!
I will fix it, and send it out soon.
Thanks,
Tony Lu
prev parent reply other threads:[~2021-11-26 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 13:24 [PATCH net v2] net/smc: Don't call clcsock shutdown twice when smc shutdown Tony Lu
2021-11-25 14:51 ` Karsten Graul
2021-11-26 2:36 ` Tony Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaBIEUO0eOUNqf0b@TonyMac-Alibaba \
--to=tonylu@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox