From: Ido Schimmel <idosch@idosch.org>
To: Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Ido Schimmel <idosch@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
Andrei Vagin <avagin@gmail.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Alexander Mikhalitsyn <alexander@mihalicyn.com>
Subject: Re: [PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set
Date: Sun, 28 Nov 2021 15:09:38 +0200 [thread overview]
Message-ID: <YaN/khA2eJJLgdte@shredder> (raw)
In-Reply-To: <20211126134311.920808-1-alexander.mikhalitsyn@virtuozzo.com>
On Fri, Nov 26, 2021 at 04:43:10PM +0300, Alexander Mikhalitsyn wrote:
> + /*
> + * Exclude flags which can't be set directly
> + * by the userspace from the rtmsg dump.
> + */
I believe iproute2 is following netdev style comments [1] so this should
be:
/* Exclude flags which can't be set directly
* by the userspace from the rtmsg dump.
*/
At least it's consistent with other comments in the file.
[1] https://www.kernel.org/doc/html/v5.12/networking/netdev-FAQ.html#is-the-comment-style-convention-different-for-the-networking-content
> + r->rtm_flags &= ~RTNH_REJECT_MASK;
> +
> ret = write(STDOUT_FILENO, n, n->nlmsg_len);
> if ((ret > 0) && (ret != n->nlmsg_len)) {
> fprintf(stderr, "Short write while saving nlmsg\n");
> --
> 2.31.1
>
prev parent reply other threads:[~2021-11-28 13:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 16:02 [RFC PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set Alexander Mikhalitsyn
2021-11-11 16:02 ` [RFC PATCH net-next] rtnetlink: add RTNH_F_REJECT_MASK Alexander Mikhalitsyn
2021-11-11 17:48 ` Jakub Kicinski
2021-11-11 17:51 ` Alexander Mikhalitsyn
2021-11-11 17:56 ` Jakub Kicinski
2021-11-11 18:01 ` Alexander Mikhalitsyn
2021-11-11 19:13 ` David Ahern
2021-11-11 19:23 ` Alexander Mikhalitsyn
2021-11-11 22:19 ` David Ahern
2021-11-12 1:02 ` Roopa Prabhu
2021-11-12 2:27 ` David Ahern
2021-11-26 13:43 ` [PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set Alexander Mikhalitsyn
2021-11-26 13:43 ` [PATCH net-next] rtnetlink: add RTNH_REJECT_MASK Alexander Mikhalitsyn
2021-11-28 14:01 ` Ido Schimmel
2021-11-29 0:19 ` David Ahern
2021-11-30 7:59 ` Ido Schimmel
2021-11-30 8:35 ` Alexander Mikhalitsyn
2021-11-30 9:28 ` Ido Schimmel
2021-11-30 9:53 ` Alexander Mikhalitsyn
2021-11-30 10:28 ` Ido Schimmel
2021-11-30 15:12 ` David Ahern
2021-11-30 8:18 ` Alexander Mikhalitsyn
2021-11-28 13:09 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaN/khA2eJJLgdte@shredder \
--to=idosch@idosch.org \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=alexander@mihalicyn.com \
--cc=avagin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=roopa@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).