netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Parav Pandit <parav@nvidia.com>,
	Vu Pham <vuhuong@nvidia.com>, Shay Drory <shayd@nvidia.com>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Wan Jiabing <wanjiabing@vivo.com>, Eli Cohen <elic@nvidia.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: SF, silence an uninitialized variable warning
Date: Sun, 28 Nov 2021 11:26:54 +0200	[thread overview]
Message-ID: <YaNLXvuDBnX1LU4y@unreal> (raw)
In-Reply-To: <20211127141953.GD24002@kili>

On Sat, Nov 27, 2021 at 05:19:53PM +0300, Dan Carpenter wrote:
> This code sometimes calls mlx5_sf_hw_table_hwc_init() when "ext_base_id"
> is uninitialized.  It's not used on that path, but it generates a static
> checker warning to pass uninitialized variables to another function.
> It may also generate runtime UBSan  warnings depending on if the
> mlx5_sf_hw_table_hwc_init() function is inlined or not.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

  reply	other threads:[~2021-11-28  9:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-27 14:19 [PATCH net-next] net/mlx5: SF, silence an uninitialized variable warning Dan Carpenter
2021-11-28  9:26 ` Leon Romanovsky [this message]
2021-12-02  6:28   ` Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaNLXvuDBnX1LU4y@unreal \
    --to=leon@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=elic@nvidia.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=shayd@nvidia.com \
    --cc=vuhuong@nvidia.com \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).