From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE12EC433F5 for ; Mon, 29 Nov 2021 14:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245425AbhK2Oer (ORCPT ); Mon, 29 Nov 2021 09:34:47 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45041 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378468AbhK2Oca (ORCPT ); Mon, 29 Nov 2021 09:32:30 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 261D25C0110; Mon, 29 Nov 2021 09:29:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 29 Nov 2021 09:29:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ODm1Tu n5Dn3eeRSRL1/FeAQ+5jHGPNz8LLO7NS3C+dI=; b=XEEm4sO++9zWX73vRCb6Gn 9y3V0VboMKm0EopFAjDPq2eN3FVqypUU7ipEkFJmPClWhgksNCx47276mi/yLazR J1rqBaAtBTjK/O39veIfRhmzDF3tSshG1YzS4aGJ/dCpLby15lNfuF/VSIYL5L0h +OZ9a2srf2h+ResbEy7Td/9f7ltgH1qTIB0sL81k65/nEfSyo23/fVN8VX1KeF+t 4NXUHxGV4LKxIeNPHKels/fRcrNj94LDW425TAduxAMj/KgaAyi3fSSOQ6fKRfIc R60VgnRMKP51YThLIcnuLFZVeBsYMvd3B6qJ8IGyvFUOwwzLu01Sb27goXN2Nsjg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheelgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcuufgt hhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrthhtvg hrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudehleet necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihguoh hstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Nov 2021 09:29:08 -0500 (EST) Date: Mon, 29 Nov 2021 16:29:04 +0200 From: Ido Schimmel To: Nikolay Aleksandrov Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, dsahern@gmail.com, Nikolay Aleksandrov Subject: Re: [PATCH net-next] net: nexthop: reduce rcu synchronizations when replacing resilient groups Message-ID: References: <20211129120924.461545-1-razor@blackwall.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211129120924.461545-1-razor@blackwall.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Nov 29, 2021 at 02:09:24PM +0200, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > We can optimize resilient nexthop group replaces by reducing the number of > synchronize_net calls. After commit 1005f19b9357 ("net: nexthop: release > IPv6 per-cpu dsts when replacing a nexthop group") we always do a > synchronize_net because we must ensure no new dsts can be created for the > replaced group's removed nexthops, but we already did that when replacing > resilient groups, so if we always call synchronize_net after any group > type replacement we'll take care of both cases and reduce synchronize_net > calls for resilient groups. > > Suggested-by: Ido Schimmel > Signed-off-by: Nikolay Aleksandrov I ran fib_nexthops.sh that used to trigger the bug fixed by commit 563f23b00253 ("nexthop: Fix division by zero while replacing a resilient group") and it looks good. Reviewed-by: Ido Schimmel Tested-by: Ido Schimmel Thanks!