From: Cong Wang <xiyou.wangcong@gmail.com>
To: Song Liu <song@kernel.org>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Cong Wang <cong.wang@bytedance.com>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Sitnicki <jakub@cloudflare.com>
Subject: Re: [PATCH bpf] libbpf: fix missing section "sk_skb/skb_verdict"
Date: Mon, 29 Nov 2021 12:50:57 -0800 [thread overview]
Message-ID: <YaU9Mdv+7kEa4JOJ@unknown> (raw)
In-Reply-To: <CAPhsuW4zR5Yuwuywd71fdfP1YXX5cw6uNmhqULHy8BhfcbEAAQ@mail.gmail.com>
On Fri, Nov 26, 2021 at 04:20:34PM -0800, Song Liu wrote:
> On Fri, Nov 26, 2021 at 12:45 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > From: Cong Wang <cong.wang@bytedance.com>
> >
> > When BPF_SK_SKB_VERDICT was introduced, I forgot to add
> > a section mapping for it in libbpf.
> >
> > Fixes: a7ba4558e69a ("sock_map: Introduce BPF_SK_SKB_VERDICT")
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: John Fastabend <john.fastabend@gmail.com>
> > Cc: Jakub Sitnicki <jakub@cloudflare.com>
> > Signed-off-by: Cong Wang <cong.wang@bytedance.com>
>
> The patch looks good to me. But seems the selftests are OK without this. So,
> do we really need this?
>
Not sure if I understand this question.
At least BPF_SK_SKB_STREAM_PARSER and BPF_SK_SKB_STREAM_VERDICT are already
there, so either we should remove all of them or add BPF_SK_SKB_VERDICT for
completeness.
Or are you suggesting we should change it back in selftests too? Note, it was
changed by Andrii in commit 15669e1dcd75fe6d51e495f8479222b5884665b6:
-SEC("sk_skb/skb_verdict")
+SEC("sk_skb")
Thanks.
next prev parent reply other threads:[~2021-11-29 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 20:41 [PATCH bpf] libbpf: fix missing section "sk_skb/skb_verdict" Cong Wang
2021-11-27 0:20 ` Song Liu
2021-11-29 20:50 ` Cong Wang [this message]
2021-11-30 23:32 ` Song Liu
2021-12-01 4:19 ` Cong Wang
2021-12-01 4:33 ` Andrii Nakryiko
2021-12-01 5:03 ` Cong Wang
2021-12-01 5:38 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaU9Mdv+7kEa4JOJ@unknown \
--to=xiyou.wangcong@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).