From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v3 2/2] net: mdio: rework mdio_uevent for mdio ethernet phy device
Date: Tue, 30 Nov 2021 09:13:50 +0000 [thread overview]
Message-ID: <YaXrTkI/KFxLmYrx@shell.armlinux.org.uk> (raw)
In-Reply-To: <1638260517-13634-2-git-send-email-zhuyinbo@loongson.cn>
On Tue, Nov 30, 2021 at 04:21:57PM +0800, Yinbo Zhu wrote:
> The of_device_uevent_modalias is service for 'of' type platform driver
> , which ask the first args must be 'of' that use MODULE_DEVICE_TABLE
> when driver was exported, but ethernet phy is a kind of 'mdio' type
> device and it is inappropriate if driver use 'of' type for exporting,
> in fact, most mainstream ethernet phy driver hasn't used 'of' type,
> even though phy driver was exported use 'of' type and it's irrelevant
> with mdio_uevent, at this time, platform_uevent was responsible for
> reporting uevent to match modules.alias configure, so, whatever that
> of_device_uevent_modalias was unnecessary, this patch was to remove it
> and add phy_id as modio uevent then ethernet phy module auto load
> function will work well.
NAK.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-11-30 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 8:21 [PATCH v3 1/2] modpost: file2alias: make mdio alias configure match mdio uevent Yinbo Zhu
2021-11-30 8:21 ` [PATCH v3 2/2] net: mdio: rework mdio_uevent for mdio ethernet phy device Yinbo Zhu
2021-11-30 9:13 ` Russell King (Oracle) [this message]
2021-11-30 9:13 ` [PATCH v3 1/2] modpost: file2alias: make mdio alias configure match mdio uevent Russell King (Oracle)
[not found] ` <ea3f6904-c610-0ee6-fbab-913ba6ae36c5@loongson.cn>
2021-12-04 9:38 ` Russell King (Oracle)
2021-12-04 21:05 ` Russell King (Oracle)
2021-12-05 15:56 ` Andrew Lunn
2021-12-05 19:02 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaXrTkI/KFxLmYrx@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).