* [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM
@ 2021-11-30 11:02 Tianchen Ding
2021-11-30 18:13 ` Andrew Lunn
2021-12-02 3:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Tianchen Ding @ 2021-11-30 11:02 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
Jakub Kicinski, Colin Foster
Cc: netdev, linux-kernel, Tianchen Ding
There's build error while CONFIG_REGMAP_MMIO is not set
and CONFIG_MDIO_MSCC_MIIM=m.
ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/net/mdio/mdio-mscc-miim.ko] undefined!
Add the depend of REGMAP_MMIO to fix it.
Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
---
drivers/net/mdio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig
index 6da1fcb25847..bfa16826a6e1 100644
--- a/drivers/net/mdio/Kconfig
+++ b/drivers/net/mdio/Kconfig
@@ -141,7 +141,7 @@ config MDIO_MVUSB
config MDIO_MSCC_MIIM
tristate "Microsemi MIIM interface support"
- depends on HAS_IOMEM
+ depends on HAS_IOMEM && REGMAP_MMIO
select MDIO_DEVRES
help
This driver supports the MIIM (MDIO) interface found in the network
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM
2021-11-30 11:02 [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM Tianchen Ding
@ 2021-11-30 18:13 ` Andrew Lunn
2021-12-02 3:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-11-30 18:13 UTC (permalink / raw)
To: Tianchen Ding
Cc: Heiner Kallweit, Russell King, David S . Miller, Jakub Kicinski,
Colin Foster, netdev, linux-kernel
On Tue, Nov 30, 2021 at 07:02:09PM +0800, Tianchen Ding wrote:
> There's build error while CONFIG_REGMAP_MMIO is not set
> and CONFIG_MDIO_MSCC_MIIM=m.
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/net/mdio/mdio-mscc-miim.ko] undefined!
>
> Add the depend of REGMAP_MMIO to fix it.
>
> Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
> Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM
2021-11-30 11:02 [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM Tianchen Ding
2021-11-30 18:13 ` Andrew Lunn
@ 2021-12-02 3:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-02 3:00 UTC (permalink / raw)
To: Tianchen Ding
Cc: andrew, hkallweit1, linux, davem, kuba, colin.foster, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 30 Nov 2021 19:02:09 +0800 you wrote:
> There's build error while CONFIG_REGMAP_MMIO is not set
> and CONFIG_MDIO_MSCC_MIIM=m.
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/net/mdio/mdio-mscc-miim.ko] undefined!
>
> Add the depend of REGMAP_MMIO to fix it.
>
> [...]
Here is the summary with links:
- net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM
https://git.kernel.org/netdev/net-next/c/8057cbb8335c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-02 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-30 11:02 [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM Tianchen Ding
2021-11-30 18:13 ` Andrew Lunn
2021-12-02 3:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).