* [PATCH] net/netfilter: remove useless type conversion to bool
@ 2021-11-24 2:18 Bernard Zhao
2021-11-30 22:10 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Bernard Zhao @ 2021-11-24 2:18 UTC (permalink / raw)
To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
David S. Miller, Jakub Kicinski, netfilter-devel, coreteam,
netdev, linux-kernel
Cc: Bernard Zhao
dying is bool, the type conversion to true/false value is not
needed.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
net/netfilter/nf_conntrack_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index f1e5443fe7c7..a6503bd188e3 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -1748,7 +1748,7 @@ ctnetlink_dump_list(struct sk_buff *skb, struct netlink_callback *cb, bool dying
res = ctnetlink_fill_info(skb, NETLINK_CB(cb->skb).portid,
cb->nlh->nlmsg_seq,
NFNL_MSG_TYPE(cb->nlh->nlmsg_type),
- ct, dying ? true : false, 0);
+ ct, dying, 0);
if (res < 0) {
if (!atomic_inc_not_zero(&ct->ct_general.use))
continue;
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/netfilter: remove useless type conversion to bool
2021-11-24 2:18 [PATCH] net/netfilter: remove useless type conversion to bool Bernard Zhao
@ 2021-11-30 22:10 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2021-11-30 22:10 UTC (permalink / raw)
To: Bernard Zhao
Cc: Jozsef Kadlecsik, Florian Westphal, David S. Miller,
Jakub Kicinski, netfilter-devel, coreteam, netdev, linux-kernel
On Tue, Nov 23, 2021 at 06:18:00PM -0800, Bernard Zhao wrote:
> dying is bool, the type conversion to true/false value is not
> needed.
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-30 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-24 2:18 [PATCH] net/netfilter: remove useless type conversion to bool Bernard Zhao
2021-11-30 22:10 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).