From: Leon Romanovsky <leonro@nvidia.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Salil Mehta <salil.mehta@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>
Subject: Re: [PATCH net-next] Revert "net: hns3: add void before function which don't receive ret"
Date: Sun, 5 Dec 2021 14:18:21 +0200 [thread overview]
Message-ID: <YayuDSbYTEdLdeMG@unreal> (raw)
In-Reply-To: <ec8b4004475049060d03fd71b916cbf32858559d.1638705082.git.leonro@nvidia.com>
On Sun, Dec 05, 2021 at 01:51:37PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> There are two issues with this patch:
> 1. devlink_register() doesn't return any value. It is already void.
> 2. It is not kernel coding at all to cast return type to void.
>
> This reverts commit 5ac4f180bd07116c1e57858bc3f6741adbca3eb6.
>
> Link: https://lore.kernel.org/all/Yan8VDXC0BtBRVGz@unreal
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c | 2 +-
> drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
It was already sent, but not merged yet.
https://lore.kernel.org/all/20211204012448.51360-1-huangguangbin2@huawei.com
Thanks
next prev parent reply other threads:[~2021-12-05 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 11:51 [PATCH net-next] Revert "net: hns3: add void before function which don't receive ret" Leon Romanovsky
2021-12-05 12:18 ` Leon Romanovsky [this message]
2021-12-07 0:34 ` Jakub Kicinski
2021-12-07 1:19 ` huangguangbin (A)
-- strict thread matches above, loose matches on Subject: below --
2021-12-04 1:24 Guangbin Huang
2021-12-07 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YayuDSbYTEdLdeMG@unreal \
--to=leonro@nvidia.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).