From: Leon Romanovsky <leon@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
Saeed Mahameed <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net/mlx5: Remove the repeated declaration
Date: Wed, 8 Dec 2021 10:59:45 +0200 [thread overview]
Message-ID: <YbB0AUPzeEjkb8bQ@unreal> (raw)
In-Reply-To: <83cb3b17-09a7-fefe-6310-8ec5b992a6a7@hisilicon.com>
On Wed, Dec 08, 2021 at 09:27:37AM +0800, Shaokun Zhang wrote:
> Hi Leon,
>
> On 2021/12/7 20:40, Leon Romanovsky wrote:
> > On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
> >> Function 'mlx5_esw_vport_match_metadata_supported' and
> >> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> >> the repeated declaration and blank line.
> >>
> >> Cc: Saeed Mahameed <saeedm@nvidia.com>
> >> Cc: Leon Romanovsky <leon@kernel.org>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> Cc: Jakub Kicinski <kuba@kernel.org>
> >> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> >> ---
> >> drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
> >> 1 file changed, 3 deletions(-)
> >>
> >
> > Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
> >
>
> Shall we need this tag since it is trivial cleanup patch?
I don't know about netdev policy about Fixes line.
IMHO, it should be always when the bug is fixed.
Thansk
>
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
>
> Thanks your reply.
>
> > .
> >
next prev parent reply other threads:[~2021-12-08 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 12:35 [PATCH] net/mlx5: Remove the repeated declaration Shaokun Zhang
2021-12-07 12:40 ` Leon Romanovsky
2021-12-08 1:27 ` Shaokun Zhang
2021-12-08 8:59 ` Leon Romanovsky [this message]
2021-12-08 15:08 ` Jakub Kicinski
2021-12-13 18:29 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbB0AUPzeEjkb8bQ@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).