From: Leon Romanovsky <leon@kernel.org>
To: Shay Drory <shayd@nvidia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
jiri@nvidia.com, saeedm@nvidia.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Moshe Shemesh <moshe@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: Re: [PATCH net-next v2 6/6] net/mlx5: Let user configure max_macs generic param
Date: Wed, 8 Dec 2021 11:24:57 +0200 [thread overview]
Message-ID: <YbB56UwaCOGO3VX+@unreal> (raw)
In-Reply-To: <20211208070350.13305-1-shayd@nvidia.com>
On Wed, Dec 08, 2021 at 09:03:50AM +0200, Shay Drory wrote:
> Currently, max_macs is taking 70Kbytes of memory per function. This
> size is not needed in all use cases, and is critical with large scale.
> Hence, allow user to configure the number of max_macs.
>
> For example, to reduce the number of max_macs to 1, execute::
> $ devlink dev param set pci/0000:00:0b.0 name max_macs value 1 \
> cmode driverinit
> $ devlink dev reload pci/0000:00:0b.0
>
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> ---
> Documentation/networking/devlink/mlx5.rst | 3 +
> .../net/ethernet/mellanox/mlx5/core/devlink.c | 67 +++++++++++++++++++
> .../net/ethernet/mellanox/mlx5/core/main.c | 21 ++++++
> include/linux/mlx5/mlx5_ifc.h | 2 +-
> 4 files changed, 92 insertions(+), 1 deletion(-)
<...>
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> index fbaab440a484..e9db12aae8f9 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -1621,7 +1621,7 @@ struct mlx5_ifc_cmd_hca_cap_bits {
>
> u8 ext_stride_num_range[0x1];
> u8 roce_rw_supported[0x1];
> - u8 reserved_at_3a2[0x1];
> + u8 log_max_current_uc_list_wr_supported[0x1];
> u8 log_max_stride_sz_rq[0x5];
> u8 reserved_at_3a8[0x3];
> u8 log_min_stride_sz_rq[0x5];
All IFC changes should be in separate patch and need to go to shared branch (mlx5-next).
Thanks
> --
> 2.21.3
>
prev parent reply other threads:[~2021-12-08 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 7:03 [PATCH net-next v2 6/6] net/mlx5: Let user configure max_macs generic param Shay Drory
2021-12-08 9:24 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbB56UwaCOGO3VX+@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).