From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <kabel@kernel.org>
Cc: Holger Brunck <holger.brunck@hitachienergy.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [v3 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output amplitude configurable
Date: Wed, 8 Dec 2021 18:00:05 +0100 [thread overview]
Message-ID: <YbDkldWhZNDRkZDO@lunn.ch> (raw)
In-Reply-To: <20211208171720.6a297011@thinkpad>
> Or maybe two properties:
> serdes-tx-amplitude-millivolt = <700 1000 1100>;
> serdes-tx-amplitude-modes = "sgmii", "2500base-x", "10gbase-r";
I think this is good. But you are missing the DT email list from Cc:
You need Robs input.
We probably should list the accepted mode values somehow. I don't know
if we can reference ethernet-controller.yaml : phy-connection-type, or
if we need a new list. This gets interesting when PCIe and USB needs
to use this property, what names are used, and if it is possible to
combine two different lists?
Andrew
next prev parent reply other threads:[~2021-12-08 17:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 19:07 [v3 1/2] Docs/devicetree: add serdes.yaml Holger Brunck
2021-12-07 19:07 ` [v3 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output amplitude configurable Holger Brunck
2021-12-07 19:27 ` Marek Behún
2021-12-08 12:29 ` Holger Brunck
2021-12-08 15:28 ` Marek Behún
2021-12-08 15:49 ` Holger Brunck
2021-12-08 16:17 ` Marek Behún
2021-12-08 16:21 ` Marek Behún
2021-12-08 16:41 ` Vladimir Oltean
2021-12-08 16:49 ` Vladimir Oltean
2021-12-08 17:00 ` Marek Behún
2021-12-08 17:19 ` Vladimir Oltean
2021-12-08 17:36 ` Marek Behún
2021-12-08 17:55 ` Andrew Lunn
2021-12-08 18:15 ` Marek Behún
2021-12-08 16:51 ` Marek Behún
2021-12-08 16:59 ` Vladimir Oltean
2021-12-08 17:10 ` Marek Behún
2021-12-08 17:12 ` Marek Behún
2021-12-08 17:20 ` Vladimir Oltean
2021-12-08 17:00 ` Andrew Lunn [this message]
2021-12-08 17:16 ` Marek Behún
2021-12-15 10:27 ` Holger Brunck
2021-12-15 20:53 ` Marek Behún
2022-01-20 7:52 ` Holger Brunck
2022-01-20 17:57 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbDkldWhZNDRkZDO@lunn.ch \
--to=andrew@lunn.ch \
--cc=holger.brunck@hitachienergy.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).