From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment
Date: Thu, 9 Dec 2021 13:58:40 +0200 [thread overview]
Message-ID: <YbHvcDhtZFTyfThT@smile.fi.intel.com> (raw)
In-Reply-To: <20211202205855.76946-1-andriy.shevchenko@linux.intel.com>
On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
>
> For the details one may look into the of_gpio_dev_init() implementation.
Marc, what do you think about this change?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-09 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 20:58 [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment Andy Shevchenko
2021-12-09 11:58 ` Andy Shevchenko [this message]
2021-12-10 13:06 ` Marc Kleine-Budde
2021-12-10 13:19 ` Andy Shevchenko
2022-01-05 14:21 ` Andy Shevchenko
2022-01-05 14:34 ` Marc Kleine-Budde
2022-01-05 14:47 ` Andy Shevchenko
2022-01-05 14:54 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbHvcDhtZFTyfThT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).