From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8B48BC433EF
	for <netdev@archiver.kernel.org>; Sat, 11 Dec 2021 19:16:36 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231814AbhLKTQf (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 11 Dec 2021 14:16:35 -0500
Received: from mail.netfilter.org ([217.70.188.207]:47422 "EHLO
        mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231765AbhLKTQe (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 11 Dec 2021 14:16:34 -0500
Received: from netfilter.org (unknown [78.30.32.163])
        by mail.netfilter.org (Postfix) with ESMTPSA id 9B2E56006E;
        Sat, 11 Dec 2021 20:14:07 +0100 (CET)
Date:   Sat, 11 Dec 2021 20:16:28 +0100
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
Cc:     Kumar Kartikeya Dwivedi <memxor@gmail.com>, bpf@vger.kernel.org,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Maxim Mikityanskiy <maximmi@nvidia.com>,
        Florian Westphal <fw@strlen.de>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 7/9] net/netfilter: Add unstable CT lookup
 helpers for XDP and TC-BPF
Message-ID: <YbT5DEmlkunw7cCo@salvia>
References: <20211210130230.4128676-1-memxor@gmail.com>
 <20211210130230.4128676-8-memxor@gmail.com>
 <YbNtmlaeqPuHHRgl@salvia>
 <20211210153129.srb6p2ebzhl5yyzh@apollo.legion>
 <YbPcxjdsdqepEQAJ@salvia>
 <87pmq3ugz5.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87pmq3ugz5.fsf@toke.dk>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sat, Dec 11, 2021 at 07:35:58PM +0100, Toke Høiland-Jørgensen wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> writes:
> 
> > On Fri, Dec 10, 2021 at 09:01:29PM +0530, Kumar Kartikeya Dwivedi wrote:
> >> On Fri, Dec 10, 2021 at 08:39:14PM IST, Pablo Neira Ayuso wrote:
> >> > On Fri, Dec 10, 2021 at 06:32:28PM +0530, Kumar Kartikeya Dwivedi wrote:
> >> > [...]
> >> > >  net/netfilter/nf_conntrack_core.c | 252 ++++++++++++++++++++++++++++++
> >> > >  7 files changed, 497 insertions(+), 1 deletion(-)
> >> > >
> >> > [...]
> >> > > diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
> >> > > index 770a63103c7a..85042cb6f82e 100644
> >> > > --- a/net/netfilter/nf_conntrack_core.c
> >> > > +++ b/net/netfilter/nf_conntrack_core.c
> >> >
> >> > Please, keep this new code away from net/netfilter/nf_conntrack_core.c
> >> 
> >> Ok. Can it be a new file under net/netfilter, or should it live elsewhere?
> >
> > IPVS and OVS use conntrack for already quite a bit of time and they
> > keep their code in their respective folders.
> 
> Those are users, though.

OK, I see this as a yet user of the conntrack infrastructure.

> This is adding a different set of exported functions, like a BPF
> version of EXPORT_SYMBOL(). We don't put those outside the module
> where the code lives either...

OVS and IPVS uses Kconfig to enable the conntrack module as a
dependency. Then, add module that is loaded when conntrack is used.

> I can buy not wanting to bloat nf_conntrack_core.c, but what's the
> problem with adding a net/netfilter_nf_conntrack_bpf.c that gets linked
> into the same kmod?

I might be missing the reason why this can't be done in
self-contained way here.