From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH net-next] net: dev: Change the order of the arguments for the contended condition.
Date: Mon, 13 Dec 2021 17:29:31 +0100 [thread overview]
Message-ID: <Ybd06waO3S5y1Q6h@linutronix.de> (raw)
In-Reply-To: <20211213081556.1a575a28@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Change the order of arguments and make qdisc_is_running() appear first.
This is more readable for the general case.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 8438553c06b8e..6d73a55ddf5f9 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3841,7 +3841,7 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q,
* sent after the qdisc owner is scheduled again. To prevent this
* scenario the task always serialize on the lock.
*/
- contended = IS_ENABLED(CONFIG_PREEMPT_RT) || qdisc_is_running(q);
+ contended = qdisc_is_running(q) || IS_ENABLED(CONFIG_PREEMPT_RT);
if (unlikely(contended))
spin_lock(&q->busylock);
--
2.34.1
next prev parent reply other threads:[~2021-12-13 16:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 15:41 [PATCH net-next] net: dev: Always serialize on Qdisc::busylock in __dev_xmit_skb() on PREEMPT_RT Sebastian Andrzej Siewior
2021-12-10 16:35 ` Paolo Abeni
2021-12-10 16:46 ` Sebastian Andrzej Siewior
2021-12-10 16:52 ` Eric Dumazet
2021-12-10 17:43 ` Sebastian Andrzej Siewior
2021-12-13 10:27 ` Paolo Abeni
2021-12-11 4:32 ` Jakub Kicinski
2021-12-13 10:45 ` Sebastian Andrzej Siewior
2021-12-13 10:53 ` [PATCH v2 " Sebastian Andrzej Siewior
2021-12-13 15:00 ` patchwork-bot+netdevbpf
2021-12-13 16:15 ` [PATCH " Jakub Kicinski
2021-12-13 16:18 ` Sebastian Andrzej Siewior
2021-12-13 16:20 ` Jakub Kicinski
2021-12-13 16:32 ` Sebastian Andrzej Siewior
2021-12-13 16:29 ` Sebastian Andrzej Siewior [this message]
2021-12-14 12:40 ` [PATCH net-next] net: dev: Change the order of the arguments for the contended condition patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybd06waO3S5y1Q6h@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).