From: Andrew Lunn <andrew@lunn.ch>
To: Andrey Eremeev <Axtone4all@yandex.ru>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED
Date: Wed, 15 Dec 2021 18:46:53 +0100 [thread overview]
Message-ID: <YboqDeIBwHE8+KcV@lunn.ch> (raw)
In-Reply-To: <20211215173032.53251-1-Axtone4all@yandex.ru>
On Wed, Dec 15, 2021 at 08:30:32PM +0300, Andrey Eremeev wrote:
> Debug print uses invalid check to detect if speed is unforced:
> (speed != SPEED_UNFORCED) should be used instead of (!speed).
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Eremeev <Axtone4all@yandex.ru>
> Fixes: 96a2b40c7bd3 ("net: dsa: mv88e6xxx: add port's MAC speed setter")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-12-15 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 17:30 [PATCH] dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED Andrey Eremeev
2021-12-15 17:46 ` Andrew Lunn [this message]
2021-12-16 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YboqDeIBwHE8+KcV@lunn.ch \
--to=andrew@lunn.ch \
--cc=Axtone4all@yandex.ru \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).