* Re: [PATCH] mlxsw: core: Switch to kvfree_rcu() API [not found] ` <20211215111845.2514-7-urezki@gmail.com> @ 2021-12-15 19:46 ` Uladzislau Rezki 2021-12-15 23:38 ` Jakub Kicinski 0 siblings, 1 reply; 2+ messages in thread From: Uladzislau Rezki @ 2021-12-15 19:46 UTC (permalink / raw) To: David S. Miller, Jakub Kicinski, netdev Cc: LKML, RCU, Paul E . McKenney, Michal Hocko, Andrew Morton, Daniel Axtens, Frederic Weisbecker, Neeraj Upadhyay, Joel Fernandes, Peter Zijlstra, Thomas Gleixner, Theodore Y . Ts'o, Sebastian Andrzej Siewior, Oleksiy Avramchenko On Wed, Dec 15, 2021 at 12:18:43PM +0100, Uladzislau Rezki (Sony) wrote: > Instead of invoking a synchronize_rcu() to free a pointer > after a grace period we can directly make use of new API > that does the same but in more efficient way. > > TO: David S. Miller <davem@davemloft.net> > TO: Jakub Kicinski <kuba@kernel.org> > TO: netdev@vger.kernel.org > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> > --- > drivers/net/ethernet/mellanox/mlxsw/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c > index 3fd3812b8f31..47c29769759b 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/core.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c > @@ -2190,8 +2190,7 @@ void mlxsw_core_rx_listener_unregister(struct mlxsw_core *mlxsw_core, > if (!rxl_item) > return; > list_del_rcu(&rxl_item->list); > - synchronize_rcu(); > - kfree(rxl_item); > + kvfree_rcu(rxl_item); > } > EXPORT_SYMBOL(mlxsw_core_rx_listener_unregister); > > -- > 2.30.2 > + David S. Miller <davem@davemloft.net> + Jakub Kicinski <kuba@kernel.org> + netdev@vger.kernel.org -- Vlad Rezki ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mlxsw: core: Switch to kvfree_rcu() API 2021-12-15 19:46 ` [PATCH] mlxsw: core: Switch to kvfree_rcu() API Uladzislau Rezki @ 2021-12-15 23:38 ` Jakub Kicinski 0 siblings, 0 replies; 2+ messages in thread From: Jakub Kicinski @ 2021-12-15 23:38 UTC (permalink / raw) To: Uladzislau Rezki Cc: David S. Miller, netdev, LKML, RCU, Paul E . McKenney, Michal Hocko, Andrew Morton, Daniel Axtens, Frederic Weisbecker, Neeraj Upadhyay, Joel Fernandes, Peter Zijlstra, Thomas Gleixner, Theodore Y . Ts'o, Sebastian Andrzej Siewior, Oleksiy Avramchenko On Wed, 15 Dec 2021 20:46:34 +0100 Uladzislau Rezki wrote: > On Wed, Dec 15, 2021 at 12:18:43PM +0100, Uladzislau Rezki (Sony) wrote: > > Instead of invoking a synchronize_rcu() to free a pointer > > after a grace period we can directly make use of new API > > that does the same but in more efficient way. > > > > TO: David S. Miller <davem@davemloft.net> > > TO: Jakub Kicinski <kuba@kernel.org> > > TO: netdev@vger.kernel.org > > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> > > --- > > drivers/net/ethernet/mellanox/mlxsw/core.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c > > index 3fd3812b8f31..47c29769759b 100644 > > --- a/drivers/net/ethernet/mellanox/mlxsw/core.c > > +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c > > @@ -2190,8 +2190,7 @@ void mlxsw_core_rx_listener_unregister(struct mlxsw_core *mlxsw_core, > > if (!rxl_item) > > return; > > list_del_rcu(&rxl_item->list); > > - synchronize_rcu(); > > - kfree(rxl_item); > > + kvfree_rcu(rxl_item); > > } > > EXPORT_SYMBOL(mlxsw_core_rx_listener_unregister); > > + David S. Miller <davem@davemloft.net> > + Jakub Kicinski <kuba@kernel.org> > + netdev@vger.kernel.org Impressive CC list. Please make a fresh posting to netdev@ and use ./scripts/get_maintainer.pl. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-15 23:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211215111845.2514-1-urezki@gmail.com>
[not found] ` <20211215111845.2514-7-urezki@gmail.com>
2021-12-15 19:46 ` [PATCH] mlxsw: core: Switch to kvfree_rcu() API Uladzislau Rezki
2021-12-15 23:38 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).