From: Andrew Lunn <andrew@lunn.ch>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Philippe Schenker <philippe.schenker@toradex.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: fec: reset phy on resume after power-up
Date: Thu, 16 Dec 2021 12:28:19 +0100 [thread overview]
Message-ID: <Ybsi00/CAd7oVl17@lunn.ch> (raw)
In-Reply-To: <20211216112433.GB4190@francesco-nb.int.toradex.com>
On Thu, Dec 16, 2021 at 12:24:33PM +0100, Francesco Dolcini wrote:
> On Thu, Dec 16, 2021 at 11:24:24AM +0100, Andrew Lunn wrote:
> > I think you need to move the regulator into phylib, so the PHY driver
> > can do the right thing. It is really the only entity which knows what
> > is the correct thing to do.
> Do you believe that the right place is the phylib and not the phy driver?
> Is this generic enough?
It is split. phylib can do the lookup in DT, get the regulator and
provide a helper to enable/disable it. So very similar to the reset.
The phy driver would then use the helpers. It probably needs to look
into the phydev structure to see what is actually available, is there
a reset, a regulator etc, and then decide what is best to do given the
available resources.
Andrew
next prev parent reply other threads:[~2021-12-16 11:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 12:16 [PATCH net-next 0/3] Add Possiblity to Reset PHY After Power-up Philippe Schenker
2021-12-14 12:16 ` [PATCH net-next 1/3] net: phy: add phy_reset_after_power_on() function Philippe Schenker
2021-12-14 12:16 ` [PATCH net-next 2/3] net: phy: micrel: add reset-after-power-on flag to ksz9x31 phys Philippe Schenker
2021-12-14 12:16 ` [PATCH net-next 3/3] net: fec: reset phy on resume after power-up Philippe Schenker
2021-12-14 18:54 ` Andrew Lunn
2021-12-14 19:09 ` Russell King (Oracle)
2021-12-14 22:35 ` Francesco Dolcini
2021-12-15 9:36 ` Andrew Lunn
2021-12-15 10:29 ` Russell King (Oracle)
2021-12-15 11:01 ` Francesco Dolcini
2021-12-15 11:10 ` Francesco Dolcini
2021-12-15 19:34 ` Andrew Lunn
2021-12-15 19:48 ` Francesco Dolcini
2021-12-16 4:52 ` Joakim Zhang
2021-12-16 7:52 ` Francesco Dolcini
2021-12-16 10:24 ` Andrew Lunn
2021-12-16 11:24 ` Francesco Dolcini
2021-12-16 11:28 ` Andrew Lunn [this message]
2021-12-16 11:31 ` Francesco Dolcini
2021-12-16 11:32 ` Andrew Lunn
2021-12-15 10:25 ` Joakim Zhang
2021-12-14 12:23 ` [PATCH net-next 0/3] Add Possiblity to Reset PHY After Power-up Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybsi00/CAd7oVl17@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=philippe.schenker@toradex.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).