From: Andrew Lunn <andrew@lunn.ch>
To: "KARL_TSOU (鄒磊)" <KARL_TSOU@ubiqconn.com>
Cc: "woojung.huh@microchip.com" <woojung.huh@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: microchip: Add supported ksz9897 port6
Date: Fri, 17 Dec 2021 10:57:30 +0100 [thread overview]
Message-ID: <YbxfCkstuBOVI2e0@lunn.ch> (raw)
In-Reply-To: <HK2PR03MB430766D15AD96E3F0E52A3D3E0789@HK2PR03MB4307.apcprd03.prod.outlook.com>
On Fri, Dec 17, 2021 at 02:53:15AM +0000, KARL_TSOU (鄒磊) wrote:
> The Microchip switch ksz9897 support 7 physical port, port 0/1/2/3/4 connect to standard RJ45, port5 connect to PHY via MII to CPU and port6 connect to PHY via RMII (PHY ksz8081) on my custom board.
Please don't top post. Also, wrap your emails so lines around 70
characters.
> I am facing a problem that I am not able to verify port6 via ping command even though the link is up, port 0/1/2/3/4 are all works fine by verifying with ping command expect port6
>
> When I go through port initialization code, a "if condition" below that aren't included port6 initialization.
This initialization is for the internal PHYs. They have to
exist. External PHYs the switch driver should not assume exist. You
normally connect to the CPU directly, not via back to back PHYs. Any
there could be boards which use port 6 direct to the CPU without a
PHY. So this change as is, is wrong.
You should be using a phy-handle in DT for port6, or port5, to
indicate if a PHY is connected to the port. Do you have this property?
Andrew
next prev parent reply other threads:[~2021-12-17 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 9:24 [PATCH] net: dsa: microchip: Add supported ksz9897 port6 KARL_TSOU (鄒磊)
2021-12-16 10:17 ` Andrew Lunn
2021-12-17 2:53 ` KARL_TSOU (鄒磊)
2021-12-17 9:57 ` Andrew Lunn [this message]
2021-12-20 3:24 ` KARL_TSOU (鄒磊)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbxfCkstuBOVI2e0@lunn.ch \
--to=andrew@lunn.ch \
--cc=KARL_TSOU@ubiqconn.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).