* [PATCH] net/smc: remove redundant re-assignment of pointer link
@ 2021-12-30 15:39 Colin Ian King
2021-12-31 6:00 ` Tony Lu
2022-01-02 12:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2021-12-30 15:39 UTC (permalink / raw)
To: Karsten Graul, David S . Miller, Jakub Kicinski, linux-s390,
netdev
Cc: kernel-janitors, linux-kernel
The pointer link is being re-assigned the same value that it was
initialized with in the previous declaration statement. The
re-assignment is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
net/smc/smc_clc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
index 8409ab71a5e4..6be95a2a7b25 100644
--- a/net/smc/smc_clc.c
+++ b/net/smc/smc_clc.c
@@ -1021,7 +1021,6 @@ static int smc_clc_send_confirm_accept(struct smc_sock *smc,
struct smc_link *link = conn->lnk;
/* SMC-R specific settings */
- link = conn->lnk;
memcpy(clc->hdr.eyecatcher, SMC_EYECATCHER,
sizeof(SMC_EYECATCHER));
clc->hdr.typev1 = SMC_TYPE_R;
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/smc: remove redundant re-assignment of pointer link
2021-12-30 15:39 [PATCH] net/smc: remove redundant re-assignment of pointer link Colin Ian King
@ 2021-12-31 6:00 ` Tony Lu
2022-01-02 12:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lu @ 2021-12-31 6:00 UTC (permalink / raw)
To: Colin Ian King
Cc: Karsten Graul, David S . Miller, Jakub Kicinski, linux-s390,
netdev, kernel-janitors, linux-kernel
On Thu, Dec 30, 2021 at 03:39:00PM +0000, Colin Ian King wrote:
> The pointer link is being re-assigned the same value that it was
> initialized with in the previous declaration statement. The
> re-assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
It would be better to add Fixes statement in the end of message.
Fixes: 387707fdf486 ("net/smc: convert static link ID to dynamic references")
And [PATCH net ...] is fine to point out the target. The patch itself
looks good to me, thanks.
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Thanks,
Tony Lu
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/smc: remove redundant re-assignment of pointer link
2021-12-30 15:39 [PATCH] net/smc: remove redundant re-assignment of pointer link Colin Ian King
2021-12-31 6:00 ` Tony Lu
@ 2022-01-02 12:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-02 12:20 UTC (permalink / raw)
To: Colin Ian King
Cc: kgraul, davem, kuba, linux-s390, netdev, kernel-janitors,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 30 Dec 2021 15:39:00 +0000 you wrote:
> The pointer link is being re-assigned the same value that it was
> initialized with in the previous declaration statement. The
> re-assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> net/smc/smc_clc.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- net/smc: remove redundant re-assignment of pointer link
https://git.kernel.org/netdev/net-next/c/3a856c14c31b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-02 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-30 15:39 [PATCH] net/smc: remove redundant re-assignment of pointer link Colin Ian King
2021-12-31 6:00 ` Tony Lu
2022-01-02 12:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).