From: Andrew Lunn <andrew@lunn.ch>
To: "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
christian.herber@nxp.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH 3/3] phy: nxp-c45-tja11xx: read the tx timestamp without lock
Date: Mon, 20 Dec 2021 16:10:43 +0100 [thread overview]
Message-ID: <YcCc84XAlckpTnkF@lunn.ch> (raw)
In-Reply-To: <20211220120859.140453-3-radu-nicolae.pirea@oss.nxp.com>
On Mon, Dec 20, 2021 at 02:08:59PM +0200, Radu Pirea (NXP OSS) wrote:
> The tx timestamps are read from only one place in interrupt or polling
> mode. Locking the mutex is useless.
You cannot take a mutex in an interrupt handler. So your description
is probably not accurate.
Is it safe for other ptp operations to be performed in parallel with
reading the TX timestamp? _nxp_c45_ptp_settime64()?
Andrew
next prev parent reply other threads:[~2021-12-20 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 12:08 [PATCH 1/3] ptp: add PTP_PEROUT_REVERSE_POLARITY flag Radu Pirea (NXP OSS)
2021-12-20 12:08 ` [PATCH 2/3] phy: nxp-c45-tja11xx: add extts and perout support Radu Pirea (NXP OSS)
2021-12-20 12:08 ` [PATCH 3/3] phy: nxp-c45-tja11xx: read the tx timestamp without lock Radu Pirea (NXP OSS)
2021-12-20 15:10 ` Andrew Lunn [this message]
2021-12-22 8:19 ` Radu Nicolae Pirea (NXP OSS)
2021-12-20 15:04 ` [PATCH 1/3] ptp: add PTP_PEROUT_REVERSE_POLARITY flag Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcCc84XAlckpTnkF@lunn.ch \
--to=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=radu-nicolae.pirea@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).