From: Andrew Lunn <andrew@lunn.ch>
To: "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Voon, Weifeng" <weifeng.voon@intel.com>,
"Wong, Vee Khee" <vee.khee.wong@intel.com>
Subject: Re: [BUG] net: phy: genphy_loopback: add link speed configuration
Date: Mon, 20 Dec 2021 16:13:45 +0100 [thread overview]
Message-ID: <YcCdqX1bq3nLGHlw@lunn.ch> (raw)
In-Reply-To: <CO1PR11MB477197B3DACAF00CCF94631ED57B9@CO1PR11MB4771.namprd11.prod.outlook.com>
On Mon, Dec 20, 2021 at 11:11:32AM +0000, Ismail, Mohammad Athari wrote:
> Hi Andrew,
>
> As the current genphy_loopback() is not applicable for Marvell
> 88E1510 PHY, should we implement Marvell specific PHY loopback
> function as below?
Yes, that is probably a good solution. We will have to see if other
PHY drivers need this as well. If they do, we might move this simple
implementation into the core. But for the moment, it can be in the
Marvell driver.
Andrew
prev parent reply other threads:[~2021-12-20 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 7:00 [BUG] net: phy: genphy_loopback: add link speed configuration Ismail, Mohammad Athari
2021-12-14 9:39 ` Andrew Lunn
2021-12-15 8:36 ` Ismail, Mohammad Athari
2021-12-15 9:23 ` Andrew Lunn
2021-12-15 9:35 ` Ismail, Mohammad Athari
2021-12-15 9:55 ` Andrew Lunn
2021-12-15 15:03 ` Ismail, Mohammad Athari
2021-12-20 11:11 ` Ismail, Mohammad Athari
2021-12-20 15:13 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcCdqX1bq3nLGHlw@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).