From: Andrew Lunn <andrew@lunn.ch>
To: Mike Ximing Chen <mike.ximing.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, dan.j.williams@intel.com,
pierre-louis.bossart@linux.intel.com, netdev@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org
Subject: Re: [RFC PATCH v12 00/17] dlb: introduce DLB device driver
Date: Tue, 21 Dec 2021 10:40:43 +0100 [thread overview]
Message-ID: <YcGhG8bdUi4WyXAf@lunn.ch> (raw)
In-Reply-To: <20211221065047.290182-1-mike.ximing.chen@intel.com>
> 1. Before a scheduling domain is created/enabled, a set of parameters are
> passed to the kernel driver via configfs attribute files in an configfs domain
> directory (say $domain) created by user. Each attribute file corresponds to
> a configuration parameter of the domain. After writing to all the attribute
> files, user writes 1 to "create" attribute, which triggers an action (i.e.,
> domain creation) in the kernel driver. Since multiple processes/users can
> access the $domain directory, multiple users can write to the attribute files
> at the same time. How do we guarantee an atomic update/configuration of a
> domain? In other words, if user A wants to set attributes 1 and 2, how can we
> prevent user B from changing attribute 1 and 2 before user A writes 1 to
> "create"? A configfs directory with individual attribute files seems to not
> be able to provide atomic configuration in this case. One option to solve this
> issue could be write a structured data (with a set of parameters) to a single
> attribute file. This would guarantee the atomic configuration, but may not be
> a conventional configfs operation.
How about throw away configfs and use netlink? Messages are atomic,
and you can add an arbitrary number of attributes to a single netlink
message. It will also make your code more network like, since nothing
else in the network stack uses configfs, as far as i know.
Andrew
next prev parent reply other threads:[~2021-12-21 9:40 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 6:50 [RFC PATCH v12 00/17] dlb: introduce DLB device driver Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver Mike Ximing Chen
2021-12-21 7:00 ` Joe Perches
2021-12-21 23:22 ` Chen, Mike Ximing
2021-12-22 2:02 ` Joe Perches
2021-12-21 7:12 ` Greg KH
2021-12-21 8:57 ` Greg KH
2021-12-21 14:25 ` Chen, Mike Ximing
2021-12-21 14:42 ` Chen, Mike Ximing
2021-12-21 15:02 ` Greg KH
2021-12-21 14:05 ` Chen, Mike Ximing
2021-12-21 9:53 ` Andrew Lunn
2021-12-21 20:56 ` Chen, Mike Ximing
2021-12-21 21:39 ` Andrew Lunn
2021-12-21 23:05 ` Chen, Mike Ximing
2021-12-22 21:26 ` Andrew Lunn
2021-12-23 5:15 ` Chen, Mike Ximing
2021-12-23 10:22 ` Andrew Lunn
2021-12-27 0:40 ` Chen, Mike Ximing
2021-12-21 6:50 ` [RFC PATCH v12 02/17] dlb: initialize DLB device Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 03/17] dlb: add resource and device initialization Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 04/17] dlb: add configfs interface and scheduling domain directory Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 05/17] dlb: add scheduling domain configuration Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 06/17] dlb: add domain software reset Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 07/17] dlb: add low-level register reset operations Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 08/17] dlb: add runtime power-management support Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 09/17] dlb: add queue create, reset, get-depth configfs interface Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 10/17] dlb: add register operations for queue management Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 11/17] dlb: add configfs interface to configure ports Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 12/17] dlb: add register operations for port management Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 13/17] dlb: add port mmap support Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 14/17] dlb: add start domain configfs attribute Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 15/17] dlb: add queue map, unmap, and pending unmap Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 16/17] dlb: add static queue map register operations Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 17/17] dlb: add basic sysfs interfaces Mike Ximing Chen
2021-12-21 7:20 ` Joe Perches
2021-12-21 23:18 ` Chen, Mike Ximing
2021-12-21 8:56 ` Greg KH
2021-12-21 14:07 ` Chen, Mike Ximing
2021-12-21 23:34 ` Stephen Hemminger
2021-12-22 4:21 ` Chen, Mike Ximing
2021-12-21 7:09 ` [RFC PATCH v12 00/17] dlb: introduce DLB device driver Greg KH
2021-12-21 14:03 ` Chen, Mike Ximing
2021-12-21 14:31 ` Greg KH
2021-12-21 18:44 ` Dan Williams
2021-12-21 19:57 ` Andrew Lunn
2021-12-22 8:01 ` Christoph Hellwig
2021-12-21 9:40 ` Andrew Lunn [this message]
2021-12-22 4:37 ` Chen, Mike Ximing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcGhG8bdUi4WyXAf@lunn.ch \
--to=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.ximing.chen@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).