From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH v1 1/1] wwan: Replace kernel.h with the necessary inclusions
Date: Thu, 23 Dec 2021 12:16:54 +0200 [thread overview]
Message-ID: <YcRMlp6ux+R0op3Q@smile.fi.intel.com> (raw)
In-Reply-To: <YcRL8Ttxm8yMj77U@smile.fi.intel.com>
On Thu, Dec 23, 2021 at 12:14:09PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 11:38:44PM +0300, Sergey Ryazanov wrote:
> > On Wed, Dec 22, 2021 at 7:32 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
...
> Not sure what it's supposed from me to do. The forward declarations are
> the tighten part of the cleanup (*) and it's exactly what is happening here,
> i.e. replacing kernel.h "with the list of what is really being used".
>
> *) Either you need a header, or you need a forward declaration, or rely on
> the compiler not to be so strict. I prefer the second option out of three.
Ah, seems indeed the skbuf and netdevice ones can be split. Do you want me to
resend as series of two?
(Sorry I have sent many similar changes and haven't remembered by heart where
I did what exactly, but here it looks natural to cleanup that stuff at the
same time, so the question is if it should be a separate change or not)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-23 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 16:32 [PATCH v1 1/1] wwan: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-12-22 20:38 ` Sergey Ryazanov
2021-12-23 10:14 ` Andy Shevchenko
2021-12-23 10:16 ` Andy Shevchenko [this message]
2021-12-23 10:46 ` Sergey Ryazanov
2021-12-23 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcRMlp6ux+R0op3Q@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).