From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
davem@davemloft.net, colin.king@intel.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] drivers: net: smc911x: Fix wrong check for irq
Date: Sat, 25 Dec 2021 16:11:45 +0100 [thread overview]
Message-ID: <Ycc0seKB4DdXiVm0@lunn.ch> (raw)
In-Reply-To: <20211224150425.3c21994f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Fri, Dec 24, 2021 at 03:04:25PM -0800, Jakub Kicinski wrote:
> On Fri, 24 Dec 2021 13:12:54 +0800 Jiasheng Jiang wrote:
> > Because ndev->irq is unsigned
>
> It's not..
https://elixir.bootlin.com/linux/v5.16-rc6/source/include/linux/netdevice.h#L2065
Definitely an int.
Andrew
prev parent reply other threads:[~2021-12-25 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 5:12 [PATCH] drivers: net: smc911x: Fix wrong check for irq Jiasheng Jiang
2021-12-24 23:04 ` Jakub Kicinski
2021-12-25 15:11 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ycc0seKB4DdXiVm0@lunn.ch \
--to=andrew@lunn.ch \
--cc=colin.king@intel.com \
--cc=davem@davemloft.net \
--cc=jiasheng@iscas.ac.cn \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).