From: Andrew Lunn <andrew@lunn.ch>
To: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@marvell.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org,
Ariel Elior <aelior@marvell.com>, Alok Prasad <palok@marvell.com>
Subject: Re: [PATCH net-next 1/1] qed: add prints if request_firmware() failed
Date: Sun, 26 Dec 2021 11:19:55 +0100 [thread overview]
Message-ID: <YchBy/UOM576Yv6d@lunn.ch> (raw)
In-Reply-To: <20211226001408.107851-1-vbhavaraju@marvell.com>
On Sat, Dec 25, 2021 at 04:14:08PM -0800, Venkata Sudheer Kumar Bhavaraju wrote:
> If driver load failed due to request_firmware() not finding the device
> firmware file, add prints that help remedy the situation.
>
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>
> Signed-off-by: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@marvell.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 46d4207f22a3..4f5d5a1e786c 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -65,6 +65,9 @@ MODULE_LICENSE("GPL");
>
> MODULE_FIRMWARE(QED_FW_FILE_NAME);
>
> +#define QED_FW_REPO \
> + "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"
linux-firmware is vendor/product neutral. So i would suggest dropping
the QED prefix. This URL is also used in a couple of other drivers, so
you could consider places it somewhere under include/linux/
Andrew
prev parent reply other threads:[~2021-12-26 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 0:14 [PATCH net-next 1/1] qed: add prints if request_firmware() failed Venkata Sudheer Kumar Bhavaraju
2021-12-26 10:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YchBy/UOM576Yv6d@lunn.ch \
--to=andrew@lunn.ch \
--cc=aelior@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=palok@marvell.com \
--cc=vbhavaraju@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).