From: Andrew Lunn <andrew@lunn.ch>
To: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@marvell.com>
Cc: netdev@vger.kernel.org, Ariel Elior <aelior@marvell.com>,
Alok Prasad <palok@marvell.com>
Subject: Re: [PATCH net-next v2 1/1] qed: add prints if request_firmware() failed
Date: Tue, 28 Dec 2021 11:27:50 +0100 [thread overview]
Message-ID: <YcrmpvMAD5zKHqTE@lunn.ch> (raw)
In-Reply-To: <20211227175656.267184-1-vbhavaraju@marvell.com>
On Mon, Dec 27, 2021 at 09:56:56AM -0800, Venkata Sudheer Kumar Bhavaraju wrote:
> If driver load failed due to request_firmware() not finding the device
> firmware file, add prints that help remedy the situation.
>
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>
> Signed-off-by: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@marvell.com>
> ---
> Changes in v2:
> - Rename QED_FW_REPO to FW_REPO
> - Move FW_REPO macro to qed_if.h
Hi Venkata
When you decide to do something different to what has been requested,
it is a good idea to say why. There might be a very good reason for
this, but unless you explain it, i have no idea what it is.
Andrew
next prev parent reply other threads:[~2021-12-28 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 17:56 [PATCH net-next v2 1/1] qed: add prints if request_firmware() failed Venkata Sudheer Kumar Bhavaraju
2021-12-28 10:27 ` Andrew Lunn [this message]
2021-12-29 11:02 ` Venkata Sudheer Kumar Bhavaraju
2021-12-29 19:13 ` Jakub Kicinski
2021-12-30 16:41 ` Andrew Lunn
2022-01-06 17:58 ` Venkata Sudheer Kumar Bhavaraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcrmpvMAD5zKHqTE@lunn.ch \
--to=andrew@lunn.ch \
--cc=aelior@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=palok@marvell.com \
--cc=vbhavaraju@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).