From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH CFT net-next] net: enetc: use .mac_select_pcs() interface
Date: Tue, 11 Jan 2022 09:56:12 +0000 [thread overview]
Message-ID: <Yd1UPIVsQfshafop@shell.armlinux.org.uk> (raw)
In-Reply-To: <AM9PR04MB83977DD63CD3DB191E79DC7D96509@AM9PR04MB8397.eurprd04.prod.outlook.com>
On Mon, Jan 10, 2022 at 05:37:55PM +0000, Claudiu Manoil wrote:
> Hi Russell,
>
> drivers/net/ethernet/freescale/enetc/enetc_pf.c: In function 'enetc_pl_mac_select_pcs':
> drivers/net/ethernet/freescale/enetc/enetc_pf.c:942:27: error: 'struct phylink_pcs' has no member named 'pcs'
> 942 | return pf->pcs ? &pf->pcs->pcs : NULL;
>
> I suppose you meant:
> - return pf->pcs ? &pf->pcs->pcs : NULL;
> + return pf->pcs;
>
> With this correction I could bring up the SGMII link on my ls1028rdb.
Thanks.
> The patch needs also rebase.
Yes, due to other patches have been merged into net-next since the patch
was sent for testing. However, now is not the time to be sending it for
net-next as the merge window is open, so there's little point rebasing
it until after the merge window has closed.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2022-01-11 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:41 [PATCH CFT net-next] net: enetc: use .mac_select_pcs() interface Russell King (Oracle)
2022-01-07 13:41 ` Russell King (Oracle)
2022-01-10 17:37 ` Claudiu Manoil
2022-01-11 8:27 ` Claudiu Manoil
2022-01-11 9:56 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd1UPIVsQfshafop@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).