From: Mark Brown <broonie@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, vladimir.oltean@nxp.com
Subject: Re: [PATCH net-next] ptp: don't include ptp_clock_kernel.h in spi.h
Date: Fri, 7 Jan 2022 17:48:19 +0000 [thread overview]
Message-ID: <Ydh842WVE/QeNwtg@sirena.org.uk> (raw)
In-Reply-To: <20220107085127.6cfaed55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]
On Fri, Jan 07, 2022 at 08:51:27AM -0800, Jakub Kicinski wrote:
> On Fri, 7 Jan 2022 16:01:33 +0000 Mark Brown wrote:
> > Nack, this is a purely SPI patch and should go via SPI (and you've not
> > even bothered to fix the subject line).
> Hold off unnecessary comments. If you want me to change something just
> tell me rather than making vague references to following "the style for
> the subsystem".
If you're unclear on feedback please do ask, in this case the issue is
that you've submitted a SPI patch with a subject line starting "ptp: "
instead of "spi: " or some close enough variant of that. The message
I sent originally is a form letter that I send for any issue with
subjects, it's not a specific thing customised.
> > It's already in my queue with that fixed.
> What does it mean that it's in "your queue" is, it does not appear in
> any branch of
> ttps://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/
I've queued it to be applied but I still need to actually do so and test
it, if it makes it through testing then it'll get merged - there's a
bunch of last minute patches running at the minute. It's far enough
along that everything applied but tests are still running.
> Will this patch make 5.17?
If there's no problem with testing it should do. I'm not sure what the
rush is though? It's just a cleanup and this is the Friday before the
merge window.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-07 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 15:56 [PATCH net-next] ptp: don't include ptp_clock_kernel.h in spi.h Jakub Kicinski
2022-01-07 16:01 ` Mark Brown
2022-01-07 16:51 ` Jakub Kicinski
2022-01-07 17:48 ` Mark Brown [this message]
2022-01-07 18:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydh842WVE/QeNwtg@sirena.org.uk \
--to=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox