netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Dimitris Michailidis <d.michailidis@fungible.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 3/8] net/funeth: probing and netdev ops
Date: Fri, 7 Jan 2022 14:40:50 +0100	[thread overview]
Message-ID: <YdhC4nykryjP+xLp@lunn.ch> (raw)
In-Reply-To: <CAOkoqZkCkyiGbUx--zY67GF05Y_XxuW6APKaqYu8F_nR9Qu7Kg@mail.gmail.com>

> > I can see this being valid if your FW is doing 802.1X. But i'm not
> > sure it is valid for other use cases. What exactly is your firmware
> > doing which stops it from handling frames?
> 
> The downtime happens occasionally after link up while the internal
> control processor is configuring the network units. So internal setup
> delays.

So it sounds like you should not be reporting carrier up until it is
actually ready to go. Carrier up means everything in the pipeline
between the MAC and the peer MAC is ready and transporting frames at
L1.

> I am told that "in the near future" the need for this will be
> removed. Trusting that near will be reasonable I'll remove this now.

O.K.

	Andrew

  reply	other threads:[~2022-01-07 13:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04  6:46 [PATCH net-next v4 0/8] new Fungible Ethernet driver Dimitris Michailidis
2022-01-04  6:46 ` [PATCH net-next v4 1/8] PCI: add Fungible vendor ID to pci_ids.h Dimitris Michailidis
2022-01-05  2:09   ` Jakub Kicinski
2022-01-04  6:46 ` [PATCH net-next v4 2/8] net/fungible: Add service module for Fungible drivers Dimitris Michailidis
2022-01-05  1:47   ` Jakub Kicinski
2022-01-05  4:28     ` Dimitris Michailidis
2022-01-05  2:09   ` Jakub Kicinski
2022-01-05  4:49     ` Dimitris Michailidis
2022-01-05  6:12       ` Dimitris Michailidis
2022-01-05 17:32         ` Jakub Kicinski
2022-01-06  0:57           ` Dimitris Michailidis
2022-01-04  6:46 ` [PATCH net-next v4 3/8] net/funeth: probing and netdev ops Dimitris Michailidis
2022-01-05  2:07   ` Jakub Kicinski
2022-01-05 15:52     ` Dimitris Michailidis
2022-01-05 16:12       ` Andrew Lunn
2022-01-07  0:53         ` Dimitris Michailidis
2022-01-07 13:40           ` Andrew Lunn [this message]
2022-01-05 17:46       ` Jakub Kicinski
2022-01-06  8:47         ` Dimitris Michailidis
2022-01-04  6:46 ` [PATCH net-next v4 4/8] net/funeth: ethtool operations Dimitris Michailidis
2022-01-04  6:46 ` [PATCH net-next v4 5/8] net/funeth: devlink support Dimitris Michailidis
2022-01-04  6:46 ` [PATCH net-next v4 6/8] net/funeth: add the data path Dimitris Michailidis
2022-01-04  6:46 ` [PATCH net-next v4 7/8] net/funeth: add kTLS TX control part Dimitris Michailidis
2022-01-04  6:46 ` [PATCH net-next v4 8/8] net/fungible: Kconfig, Makefiles, and MAINTAINERS Dimitris Michailidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdhC4nykryjP+xLp@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=d.michailidis@fungible.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).