From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Pali Rohár" <pali@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>, "Marek Behún" <kabel@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] of: net: Add helper function of_get_ethdev_label()
Date: Fri, 7 Jan 2022 16:29:31 +0000 [thread overview]
Message-ID: <Ydhqa+9ya6nHsvLq@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220107161222.14043-1-pali@kernel.org>
On Fri, Jan 07, 2022 at 05:12:21PM +0100, Pali Rohár wrote:
> Adds a new helper function of_get_ethdev_label() which sets initial name of
> specified netdev interface based on DT "label" property. It is same what is
> doing DSA function dsa_port_parse_of() for DSA ports.
>
> This helper function can be useful for drivers to make consistency between
> DSA and netdev interface names.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Doesn't this also need a patch to update the DT binding document
Documentation/devicetree/bindings/net/ethernet-controller.yaml ?
Also it needs a covering message for the series, and a well thought
out argument why this is required. Consistency with DSA probably
isn't a good enough reason.
From what I remember, there have been a number of network interface
naming proposals over the years, and as you can see, none of them have
been successful... but who knows what will happen this time.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-01-07 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 16:12 [PATCH 1/2] of: net: Add helper function of_get_ethdev_label() Pali Rohár
2022-01-07 16:12 ` [PATCH 2/2] of: net: Call of_get_ethdev_label() in all DT based net drivers Pali Rohár
2022-01-07 16:29 ` Russell King (Oracle) [this message]
2022-01-07 16:55 ` [PATCH 1/2] of: net: Add helper function of_get_ethdev_label() Andrew Lunn
2022-01-13 18:27 ` Pali Rohár
2022-02-08 11:00 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydhqa+9ya6nHsvLq@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).