From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "Jesper Dangaard Brouer" <jbrouer@redhat.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>,
"Zvi Effron" <zeffron@riotgames.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Shay Agroskin" <shayagr@amazon.com>,
"john fastabend" <john.fastabend@gmail.com>,
"David Ahern" <dsahern@kernel.org>,
"Eelco Chaudron" <echaudro@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Alexander Duyck" <alexander.duyck@gmail.com>,
"Saeed Mahameed" <saeed@kernel.org>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
tirthendu.sarkar@intel.com
Subject: Re: [PATCH v21 bpf-next 18/23] libbpf: Add SEC name for xdp_mb programs
Date: Fri, 14 Jan 2022 00:58:40 +0100 [thread overview]
Message-ID: <YeC8sOAeZjpc4j8+@lore-desk> (raw)
In-Reply-To: <CAADnVQJaB8mmnD1Z4jxva0CqA2D0aQDmXggMEQPX2MRLZvoLzA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]
> On Thu, Jan 13, 2022 at 2:22 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> > > > >
> > > > > I would prefer to keep the "_mb" postfix, but naming is hard and I am
> > > > > polarized :)
> > > >
> > > > I would lean towards keeping _mb as well, but if it does have to be
> > > > changed why not _mbuf? At least that's not quite as verbose :)
> > >
> > > I dislike the "mb" abbreviation as I forget it stands for multi-buffer.
> > > I like the "mbuf" suggestion, even-though it conflicts with (Free)BSD mbufs
> > > (which is their SKB).
> >
> > If we all agree, I can go over the series and substitute mb postfix with mbuf.
> > Any objections?
>
> mbuf has too much bsd taste.
>
> How about ".frags" instead?
I am fine with this (for me it is better than mb or mbuf).
Do we all agree or do we prefer the "mb" suffix?
> Then xdp_buff_is_mb() will be xdp_buff_has_frags().
>
> I agree that it's not obvious what "mb" suffix stands for,
> but I don't buy at all that it can be confused with "megabyte".
> It's the context that matters.
> In "100mb" it's obvious that "mb" is likely "megabyte",
> but in "xdp.mb" it's certainly not "xdp megabyte".
> Such a sentence has no meaning.
> Imagine we used that suffix for "tc"...
> it would be "tc.mb"... "Traffic Control Megabyte" ??
>
> Anyway "xdp.frags" ?
agree
>
> Btw "xdp_cpumap" should be cleaned up.
> xdp_cpumap is an attach type. It's not prog type.
> Probably it should be "xdp/cpumap" to align with "cgroup/bind[46]" ?
so for xdp "mb" or xdp "frags" it will be xdp/cpumap.mb (xdp/devmap.mb) or
xdp/cpumap.frags (xdp/devmap.frags), right?
>
> In patch 22 there is a comment:
> /* try to attach BPF_XDP_DEVMAP multi-buff program"
>
> It creates further confusion. There is no XDP_DEVMAP program type.
> It should probably read
> "Attach BPF_XDP program with frags to devmap"
ack, I will fix it.
>
> Patch 21 still has "CHECK". Pls replace it with ASSERT.
ack, I will fix it.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-01-13 23:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 11:53 [PATCH v21 bpf-next 00/23] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 01/23] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 02/23] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 03/23] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 04/23] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 05/23] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 06/23] net: marvell: rely on " Lorenzo Bianconi
2022-01-10 16:37 ` Andy Gospodarek
2022-01-11 13:05 ` Lorenzo Bianconi
2022-01-11 14:29 ` Andy Gospodarek
2022-01-08 11:53 ` [PATCH v21 bpf-next 07/23] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 08/23] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 09/23] bpf: introduce BPF_F_XDP_MB flag in prog_flags loading the ebpf program Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 10/23] net: mvneta: enable jumbo frames if the loaded XDP program support mb Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 11/23] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 12/23] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 13/23] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 14/23] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 15/23] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 16/23] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 17/23] bpf: selftests: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 18/23] libbpf: Add SEC name for xdp_mb programs Lorenzo Bianconi
2022-01-10 2:16 ` Andrii Nakryiko
2022-01-12 18:17 ` Lorenzo Bianconi
2022-01-12 18:24 ` Andrii Nakryiko
2022-01-12 18:35 ` Lorenzo Bianconi
2022-01-12 19:16 ` Alexei Starovoitov
2022-01-12 19:20 ` Andrii Nakryiko
2022-01-12 19:47 ` Alexei Starovoitov
2022-01-12 20:04 ` Zvi Effron
2022-01-12 20:12 ` Lorenzo Bianconi
2022-01-12 22:04 ` Toke Høiland-Jørgensen
2022-01-13 9:38 ` Jesper Dangaard Brouer
2022-01-13 10:22 ` Lorenzo Bianconi
2022-01-13 20:19 ` Alexei Starovoitov
2022-01-13 23:58 ` Lorenzo Bianconi [this message]
2022-01-14 2:09 ` Alexei Starovoitov
2022-01-14 16:50 ` Jesper Dangaard Brouer
2022-01-14 18:55 ` Zvi Effron
2022-01-14 19:36 ` Andrii Nakryiko
2022-01-14 16:35 ` Lorenzo Bianconi
2022-01-14 19:35 ` Andrii Nakryiko
2022-01-08 11:53 ` [PATCH v21 bpf-next 19/23] bpf: generalise tail call map compatibility check Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 20/23] net: xdp: introduce bpf_xdp_pointer utility routine Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 21/23] bpf: selftests: introduce bpf_xdp_{load,store}_bytes selftest Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 22/23] bpf: selftests: add CPUMAP/DEVMAP selftests for xdp multi-buff Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 23/23] xdp: disable XDP_REDIRECT " Lorenzo Bianconi
2022-01-12 18:55 ` [PATCH v21 bpf-next 00/23] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeC8sOAeZjpc4j8+@lore-desk \
--to=lorenzo@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=jbrouer@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shayagr@amazon.com \
--cc=tirthendu.sarkar@intel.com \
--cc=toke@redhat.com \
--cc=zeffron@riotgames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).