From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, linux@rempel-privat.de,
andrew@lunn.ch, oneukum@suse.com, robert.foss@collabora.com,
freddy@asix.com.tw, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+6ca9f7867b77c2d316ac@syzkaller.appspotmail.com
Subject: Re: [PATCH RFT] net: asix: add proper error handling of usb read errors
Date: Tue, 18 Jan 2022 07:18:52 +0100 [thread overview]
Message-ID: <YeZbzM6TDCIEvCUc@kroah.com> (raw)
In-Reply-To: <d2a4ad77-3ade-9319-f99c-82201c4268e5@gmail.com>
On Mon, Jan 17, 2022 at 10:31:21PM +0300, Pavel Skripkin wrote:
> On 1/5/22 16:19, Pavel Skripkin wrote:
> > Syzbot once again hit uninit value in asix driver. The problem still the
> > same -- asix_read_cmd() reads less bytes, than was requested by caller.
> >
> > Since all read requests are performed via asix_read_cmd() let's catch
> > usb related error there and add __must_check notation to be sure all
> > callers actually check return value.
> >
> > So, this patch adds sanity check inside asix_read_cmd(), that simply
> > checks if bytes read are not less, than was requested and adds missing
> > error handling of asix_read_cmd() all across the driver code.
> >
> > Fixes: d9fe64e51114 ("net: asix: Add in_pm parameter")
> > Reported-and-tested-by: syzbot+6ca9f7867b77c2d316ac@syzkaller.appspotmail.com
> > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> > ---
>
> gentle ping :)
It's the middle of a merge window, and you ask for testing before it can
be applied?
confused,
greg k-h
next prev parent reply other threads:[~2022-01-18 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 13:19 [PATCH RFT] net: asix: add proper error handling of usb read errors Pavel Skripkin
2022-01-05 14:15 ` Oleksij Rempel
2022-01-17 19:31 ` Pavel Skripkin
2022-01-18 6:18 ` Greg KH [this message]
2022-01-18 19:00 ` Pavel Skripkin
2022-02-06 17:23 ` Pavel Skripkin
2022-02-06 17:48 ` Oleksij Rempel
2022-02-06 18:05 ` [PATCH net-next] " Pavel Skripkin
2022-02-07 10:27 ` Greg KH
2022-02-07 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeZbzM6TDCIEvCUc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=paskripkin@gmail.com \
--cc=robert.foss@collabora.com \
--cc=syzbot+6ca9f7867b77c2d316ac@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).