From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4986FC43219 for ; Tue, 18 Jan 2022 09:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345312AbiARJdH (ORCPT ); Tue, 18 Jan 2022 04:33:07 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:51592 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235807AbiARJc5 (ORCPT ); Tue, 18 Jan 2022 04:32:57 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D9DC1B81223; Tue, 18 Jan 2022 09:32:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76C83C00446; Tue, 18 Jan 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642498373; bh=DQsfwtJhv3xPa9stElQYzBQziBxi/lTSvFxbATxprog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYXMJ0VPjFYSJY4NvlXmFWheHw/XkPbDg6jYdIXLJdD1zglfnvz6feJDneqRQF/Y7 Xd4h6nOb3hzFwTMGSfrGLMZs9cs+U1HvQaFyP49TIVznh2RAxc+V/DqmrD1t1xwr2a 25A0Y8zcDbS1ew90c5vIYgg7oo/j34B2Guk1t+0Y= Date: Tue, 18 Jan 2022 10:32:50 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Liam Girdwood , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, Lee Jones , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Tony Luck , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , Matthias Brugger , platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , openipmi-developer@lists.sourceforge.net, Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Sergey Shtylyov , Richard Weinberger , Mun Yew Tham , Hans de Goede , netdev@vger.kernel.org, Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) Message-ID: References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 18, 2022 at 10:18:19AM +0100, Uwe Kleine-König wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote: > > > A possible compromise: We can have both. We rename > > > platform_get_irq_optional() to platform_get_irq_silent() (or > > > platform_get_irq_silently() if this is preferred) and once all users are > > > are changed (which can be done mechanically), we reintroduce a > > > platform_get_irq_optional() with Sergey's suggested semantic (i.e. > > > return 0 on not-found, no error message printking). > > > > Please do not do that as anyone trying to forward-port an old driver > > will miss the abi change of functionality and get confused. Make > > build-breaking changes, if the way a function currently works is > > changed in order to give people a chance. > > Fine for me. I assume this is a Nack for Sergey's patch? This set of patches is going nowhere as-is, sorry. The thread is too confusing and people are not agreeing at all. greg k-h