netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: phy: marvell: Honor phy LED set by system firmware on a Dell hardware
Date: Fri, 21 Jan 2022 16:08:47 +0100	[thread overview]
Message-ID: <YerMf2wl7KSLpx8Y@lunn.ch> (raw)
In-Reply-To: <CAAd53p6C5SsYwKt4xsJ+qiqhrF45UW_VG8O+EiJcgeWy=MqzPw@mail.gmail.com>

> The Marvell PHY on the system doesn't support WoL.

Not technically correct. The PHY does, the way the PHY has been
integrated into the system does not.

But again, you need to think of the general case. Somebody else wants
to make use of this feature of not touching the LED configuration, but
does have a system were WoL works. What does that imply?

     Andrew

  reply	other threads:[~2022-01-21 15:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20  5:19 [PATCH v2] net: phy: marvell: Honor phy LED set by system firmware on a Dell hardware Kai-Heng Feng
2022-01-20  7:58 ` Heiner Kallweit
2022-01-20 11:40   ` Kai-Heng Feng
2022-01-20 13:46 ` Andrew Lunn
2022-01-21  3:54   ` Kai-Heng Feng
2022-01-21 13:04     ` Andrew Lunn
2022-01-21 14:04       ` Kai-Heng Feng
2022-01-21 15:05         ` Andrew Lunn
2022-01-21 13:10     ` Andrew Lunn
2022-01-21 14:06       ` Kai-Heng Feng
2022-01-21 15:08         ` Andrew Lunn [this message]
2022-01-21  7:49   ` Heiner Kallweit
2022-01-20 14:26 ` Andrew Lunn
2022-01-21  4:01   ` Kai-Heng Feng
2022-01-21 13:22     ` Andrew Lunn
2022-01-21 14:17       ` Kai-Heng Feng
2022-01-21 15:15         ` Andrew Lunn
2022-01-22 19:13           ` Heiner Kallweit
2022-01-22 21:18             ` Andrew Lunn
2022-02-14  5:40               ` Kai-Heng Feng
2022-02-15 20:27                 ` Andrew Lunn
2022-02-16  2:30                   ` Kai-Heng Feng
2022-02-16  7:39                     ` Andrew Lunn
2022-01-20 15:33 ` kernel test robot
2022-01-21  6:47 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YerMf2wl7KSLpx8Y@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).