netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] sunhme: fix the version number in struct ethtool_drvinfo
Date: Sat, 5 Feb 2022 15:48:41 +0100	[thread overview]
Message-ID: <Yf6OSc78JScHNgag@lunn.ch> (raw)
In-Reply-To: <5538622.DvuYhMxLoT@eto.sf-tec.de>

> > > struct ethtool_drvinfo *info> 
> > >  {
> > >  
> > >  	struct happy_meal *hp = netdev_priv(dev);
> > > 
> > > -	strlcpy(info->driver, "sunhme", sizeof(info->driver));
> > > -	strlcpy(info->version, "2.02", sizeof(info->version));
> > > +	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
> > > +	strlcpy(info->version, DRV_VERSION, sizeof(info->version));
> > 
> > I would suggest you drop setting info->version. The kernel will fill
> > it with the current kernel version, which is much more meaningful.
> 
> Would it make sense to completely remove the version number from the driver 
> then?

If it is not used anywhere else, yes, you can remove it.

   Andrew

  reply	other threads:[~2022-02-05 14:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03 16:20 sunhme: some cleanups Rolf Eike Beer
2022-02-03 16:21 ` [PATCH 1/3] sunhme: remove unused tx_dump_ring() Rolf Eike Beer
2022-07-27  3:42   ` Sean Anderson
2022-02-03 16:22 ` [PATCH 2/3] sunhme: fix the version number in struct ethtool_drvinfo Rolf Eike Beer
2022-02-03 17:12   ` Andrew Lunn
2022-02-05 11:27     ` Rolf Eike Beer
2022-02-05 14:48       ` Andrew Lunn [this message]
2022-02-05 15:57         ` Rolf Eike Beer
2022-02-05 16:32           ` Andrew Lunn
2022-02-03 21:53   ` Jakub Kicinski
2022-02-14 18:33   ` [PATCH 2/3 v2] " Rolf Eike Beer
2022-02-03 16:23 ` [PATCH 3/3] sunhme: forward the error code from pci_enable_device() Rolf Eike Beer
2022-07-27  3:48   ` Sean Anderson
2022-02-14 18:31 ` [PATCH 4/x] sunhme: switch to devres Rolf Eike Beer
2022-07-27  3:49   ` Sean Anderson
2022-07-27  3:58     ` Sean Anderson
2022-07-28 19:52       ` Rolf Eike Beer
2022-07-29  0:33         ` Sean Anderson
2022-08-01 15:14           ` Rolf Eike Beer
2022-08-24 15:45             ` Rolf Eike Beer
2022-08-24 15:57               ` Sean Anderson
2022-08-29 13:22   ` [PATCH 4/4 v2] " Rolf Eike Beer
2022-08-30  0:16     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yf6OSc78JScHNgag@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=eike-kernel@sf-tec.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).