From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: Re: [PATCH net-next v2 2/3] net: dev: Makes sure netif_rx() can be invoked in any context.
Date: Sat, 5 Feb 2022 21:36:05 +0100 [thread overview]
Message-ID: <Yf7ftf+6j52opu5w@linutronix.de> (raw)
In-Reply-To: <20220204201715.44f48f4f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2022-02-04 20:17:15 [-0800], Jakub Kicinski wrote:
> On Fri, 4 Feb 2022 21:12:58 +0100 Sebastian Andrzej Siewior wrote:
> > +int __netif_rx(struct sk_buff *skb)
> > +{
> > + int ret;
> > +
> > + trace_netif_rx_entry(skb);
> > + ret = netif_rx_internal(skb);
> > + trace_netif_rx_exit(ret);
> > + return ret;
> > +}
>
> Any reason this is not exported? I don't think there's anything wrong
> with drivers calling this function, especially SW drivers which already
> know to be in BH. I'd vote for roughly all of $(ls drivers/net/*.c) to
> get the same treatment as loopback.
Don't we end up in the same situation as netif_rx() vs netix_rx_ni()?
Sebastian
next prev parent reply other threads:[~2022-02-05 20:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 20:12 [PATCH net-next v2 0/3] net: dev: PREEMPT_RT fixups Sebastian Andrzej Siewior
2022-02-04 20:12 ` [PATCH net-next v2 1/3] net: dev: Remove preempt_disable() and get_cpu() in netif_rx_internal() Sebastian Andrzej Siewior
2022-02-04 23:44 ` Toke Høiland-Jørgensen
2022-02-04 20:12 ` [PATCH net-next v2 2/3] net: dev: Makes sure netif_rx() can be invoked in any context Sebastian Andrzej Siewior
2022-02-04 23:44 ` Toke Høiland-Jørgensen
2022-02-05 4:17 ` Jakub Kicinski
2022-02-05 20:36 ` Sebastian Andrzej Siewior [this message]
2022-02-07 16:47 ` Jakub Kicinski
2022-02-10 12:22 ` Sebastian Andrzej Siewior
2022-02-10 18:13 ` Jakub Kicinski
2022-02-10 19:52 ` Sebastian Andrzej Siewior
2022-02-04 20:12 ` [PATCH net-next v2 3/3] net: dev: Make rps_lock() disable interrupts Sebastian Andrzej Siewior
2022-02-05 4:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf7ftf+6j52opu5w@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).