From: Alexey Sheplyakov <asheplyakov@basealt.ru>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Dmitry Dunaev <dmitry.dunaev@baikalelectronics.ru>
Subject: Re: [PATCH 1/2] net: stmmac: added Baikal-T1/M SoCs glue layer
Date: Fri, 28 Jan 2022 21:00:19 +0400 [thread overview]
Message-ID: <YfQhCMrySoza9Ykt@asheplyakov-rocket> (raw)
In-Reply-To: <20220126170042.17ae0ad8@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Hi, Jakub,
On Wed, Jan 26, 2022 at 05:00:42PM -0800, Jakub Kicinski wrote:
> On Wed, 26 Jan 2022 12:44:55 +0400 Alexey Sheplyakov wrote:
> > The gigabit Ethernet controller available in Baikal-T1 and Baikal-M
> > SoCs is a Synopsys DesignWare MAC IP core, already supported by
> > the stmmac driver.
> >
> > This patch implements some SoC specific operations (DMA reset and
> > speed fixup) necessary for Baikal-T1/M variants.
>
> drivers/net/ethernet/stmicro/stmmac/dwmac-baikal.c:33:13: warning: unused variable ‘err’ [-Wunused-variable]
> 33 | int err;
> | ^~~
thanks for spotting this. I've sent v2 patchset which appears to compile
with -Werror.
Best regards,
Alexey
next prev parent reply other threads:[~2022-01-28 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 8:44 [PATCH 1/2] net: stmmac: added Baikal-T1/M SoCs glue layer Alexey Sheplyakov
2022-01-26 8:44 ` [PATCH 2/2] dt-bindings: dwmac: Add bindings for Baikal-T1/M SoCs Alexey Sheplyakov
2022-01-27 1:00 ` [PATCH 1/2] net: stmmac: added Baikal-T1/M SoCs glue layer Jakub Kicinski
2022-01-28 12:16 ` [PATCH v2 " Alexey Sheplyakov
2022-01-28 12:16 ` [PATCH v2 2/2] dt-bindings: dwmac: Add bindings for Baikal-T1/M SoCs Alexey Sheplyakov
2022-01-28 17:00 ` Alexey Sheplyakov [this message]
2022-01-28 15:06 ` [PATCH 1/2] net: stmmac: added Baikal-T1/M SoCs glue layer Serge Semin
2022-01-28 18:55 ` Alexey Sheplyakov
2022-01-28 20:27 ` Jakub Kicinski
2022-02-01 15:54 ` Serge Semin
2022-02-01 19:08 ` Jakub Kicinski
2022-02-07 15:22 ` Serge Semin
2022-02-03 10:49 ` Alexey Sheplyakov
2022-02-07 17:48 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfQhCMrySoza9Ykt@asheplyakov-rocket \
--to=asheplyakov@basealt.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=dmitry.dunaev@baikalelectronics.ru \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox