From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFC3C433FE for ; Tue, 1 Feb 2022 08:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbiBAI6J (ORCPT ); Tue, 1 Feb 2022 03:58:09 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:47068 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231912AbiBAI6I (ORCPT ); Tue, 1 Feb 2022 03:58:08 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E938B829FF; Tue, 1 Feb 2022 08:58:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98DCAC340EB; Tue, 1 Feb 2022 08:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643705885; bh=LJC9n48OTYLp63zl+exwNah6LkVop56GME45IY3BMi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fIyx4WxNNVEXVLk59f/rhXF1OskrwHehVQ/uiBgXfDkxSWC28qHfoCuo32ZdPZIup PH/+qCMHCt7OEQ10bCaoOMnjXcGCIhf5xYnN/nwdS1KNvwoyVThqCcBj4pBObozPI1 UF0qUANT0A4nkVbkvOk9NnY7JvKxfhxLjrUJ3/MxA/HKZByHw70vq+gBJ5XDhR9jaE 13VvHn/1gEknI6TC2aISYAbrXHAAnt1QkOwFlj8up2XHAITP5Qs8eioVuSxP8DN95q TN3s9dP8bi51bPvGzhNyIp758G5dm1qJzAJWBtyfYPw1300wt0mzSIdQ5jl0THB4GW ysMV9eZksg/qA== Date: Tue, 1 Feb 2022 10:58:01 +0200 From: Leon Romanovsky To: Hisashi T Fujinaka Cc: Florian Fainelli , Saeed Mahameed , Geert Uytterhoeven , Geert Uytterhoeven , David Awogbemila , Linus Walleij , rafal@milecki.pl, Horatiu Vultur , Andy Gospodarek , Edwin Peer , Wei Liu , Michal Simek , Christophe Leroy , linux-sunxi@lists.linux.dev, Jiri Pirko , l.stelmach@samsung.com, Shay Agroskin , Randy Dunlap , linux-kernel@vger.kernel.org, Jon Mason , Shannon Nelson , Claudiu Beznea , Alexandre Belloni , Chris Snook , Zhu Yanjun , Arthur Kiyanovski , Stefan Wahren , Stephen Hemminger , linux-stm32@st-md-mailman.stormreply.com, Gabriel Somlo , Rain River , Martin Habets , Yisen Zhuang , Jose Abreu , Shai Malin , Maxime Ripard , Claudiu Manoil , drivers@pensando.io, Omkar Kulkarni , linux-arm-kernel@lists.infradead.org, Vegard Nossum , David Arinzon , Microchip Linux Driver Support , linux-renesas-soc@vger.kernel.org, Maxime Coquelin , Catherine Sullivan , linux-hyperv@vger.kernel.org, oss-drivers@corigine.com, Noam Dagan , Rob Herring , Steen Hegelund , Dexuan Cui , Jernej Skrabec , Chen-Yu Tsai , Joel Stanley , Simon Horman , Asmaa Mnebhi , Arnd Bergmann , Haiyang Zhang , Saeed Mahameed , Liming Sun , Michael Chan , Salil Mehta , Sergey Shtylyov , Oleksij Rempel , Edward Cree , Saeed Bishara , Mark Einon , "David S. Miller" , Vignesh Raghavendra , Vladimir Oltean , Alexandre Torgue , Slark Xiao , Gary Guo , Gerhard Engleder , Jeroen de Borst , Lino Sanfilippo , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Prabhakar Kushwaha , Hans Ulli Kroll , Richard Cochran , Marcin Wojtas , David Thompson , Lars Povlsen , netdev@vger.kernel.org, Nicolas Ferre , Stephen Hemminger Subject: Re: [Intel-wired-lan] [PATCH net-next] net: kbuild: Don't default net vendor configs to y Message-ID: References: <20220131172450.4905-1-saeed@kernel.org> <20220131095905.08722670@hermes.local> <20220131183540.6ekn3z7tudy5ocdl@sx1> <30ed8220-e24d-4b40-c7a6-4b09c84f9a1f@gmail.com> <09c97169-5f9a-fc8f-dea5-5423e7bfef34@twofifty.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09c97169-5f9a-fc8f-dea5-5423e7bfef34@twofifty.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 31, 2022 at 10:55:14AM -0800, Hisashi T Fujinaka wrote: > On Mon, 31 Jan 2022, Florian Fainelli wrote: > > > On 1/31/2022 10:35 AM, Saeed Mahameed wrote: > > > On 31 Jan 19:30, Geert Uytterhoeven wrote: > > > > On Mon, Jan 31, 2022 at 6:59 PM Stephen Hemminger > > > > wrote: > > > > > On Mon, 31 Jan 2022 09:24:50 -0800 > > > > > Saeed Mahameed wrote: > > > > > > > > > > > From: Saeed Mahameed > > > > > > > > > > > > NET_VENDOR_XYZ were defaulted to 'y' for no technical reason. > > > > > > > > > > > > Since all drivers belonging to a vendor are supposed to default to 'n', > > > > > > defaulting all vendors to 'n' shouldn't be an issue, and aligns well > > > > > > with the 'no new drivers' by default mentality. > > > > > > > > > > > > Signed-off-by: Saeed Mahameed > > > > > > > > > > This was done back when vendors were introduced in the > > > > > network drivers tree. > > > > > The default of Y allowed older configurations to just work. > > > > > > > > And changing the defaults means all defconfigs must be updated first, > > > > else the user's configs will end up without drivers needed. > > > > > > > > > > As I understand correctly, at least for most common net drivers, > > > having NET_VENDOR_XYZ=y doesn't actually build anything, we have > > > flags per > > > module for each vendor and those are defaulted to N. > > > > Right, but once you start hiding NET_VENDOR_DRIVER_XYZ under a > > NET_VENDOR_XYZ Kconfig symbol dependency, if NET_VENDOR_XYZ is not set > > to Y, then you have no way to select NET_VENDOR_DRIVER_XYZ and so your > > old defconfig breaks. > > > > > > > > > > So there was a reason, not sure if it matters anymore. > > > > > But it seems like useless repainting to change it now. > > > > > > > > It might make sense to tune some of the defaults (i.e. change to > > > > "default y if ARCH_*") for drivers with clear platform dependencies. > > > > > > > > > > either set hard default to 'n' or just keep it as is, anything else is just > > > more confusion. > > > > Maybe the rule should go like this: any new driver vendor defaults to n, > > and existing ones remain set to y, until we deprecate doing that and > > switching them all off to n by 5.18? > > Forgive my ignorance, but isn't it a regression if things quit working > even if it's just a configuration change? No, kernel configs never were declared as ABI as "regular" users are not supposed to touch it. They use something provided by the distro. > > From a user perspective I like having everything turned on initially so > it just works. Pruning things down is a lot easier than trying to figure > out what all to turn on. Especially in graphics. I have completely opposite view here and prefer to have minimal config for my CI, and for my working machines as well. Thanks > > -- > Hisashi T Fujinaka - htodd@twofifty.com