From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8365AC433EF for ; Thu, 17 Feb 2022 01:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbiBQB0H (ORCPT ); Wed, 16 Feb 2022 20:26:07 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbiBQB0G (ORCPT ); Wed, 16 Feb 2022 20:26:06 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5F9D2A0D4A for ; Wed, 16 Feb 2022 17:25:53 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id l19so3677933pfu.2 for ; Wed, 16 Feb 2022 17:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+619F6UacS3FbkkNMbsN7cTPEX+VxrRPyLNfw4lOdq0=; b=nAKfLKGap19KmidpC9uqf+5gNyW110ZlIwlOaiFHKL+5uyWVO7T6E+WCNGEKJj8d5m sadD08gONkP6vToNtR4axn6BLt3DesGoCgb10PpsjRBkEIGrIwgKGQSNzzECtD9pIruZ ciTZKOn7+HP+nArRrq2JQ1MXKb9Bgnoyf0Lji+peylWxlpXRdisn14qSamgnZpHmkVsk jWG68rCop7Xv8fq53FEcIQnSwnyB8y789Chgb8T2vxT6UOCnkUK/4DlkwQGzv6+1JhXZ l8KcZ1SjDAMgu2a0ldzEo8yciJVthZEGQnFE/lCS2lTdDvoAhAHG7J7ZMQsI1CqFDU+T 6MMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+619F6UacS3FbkkNMbsN7cTPEX+VxrRPyLNfw4lOdq0=; b=fqp/+w8WWn804mIfO9+jCTCjPdQAn9ytHWy8gBHm1PyF/H07pnKbU/qBR64HMBoP8B nLDeF/Q8dxarHgYayd91AdtQdV/tF6vHZzo70e9fyNI3qLHxZuRsY8PfgCls3P5dak0I h20dubUQ9MB06Sm8vNx0GZ2VjzkvQV0NDsbgW3zBID7nJAmvXhYtRGWP+Wrh0GkfGFAe 7lYWWa/wrwCsTdK7AIHhHwdxK8lFlmGVQrSLL8eGoLnFB6x+umAy6fq+Lzv0gi7ajaEf bsUOwaquEcCwwQzf0peDs3/Z1mCmZsXUmMcoGIhP+Tiq7V7p+rv/VOpbkJQRzx5MZ7fX smaQ== X-Gm-Message-State: AOAM532TvyYV4XNRovQKlck2z6mpOlmGZcky3ucwesdHf4MF56lkaem5 ulq/n8mLiBqRRfjtmJsf2q8= X-Google-Smtp-Source: ABdhPJwBEhjFzsx8GiiAl6fMii1q8iAPq35CZBVg+Q49+PZAlbjXh9hcIwnBp9qToW514pR3mP9Zmw== X-Received: by 2002:a63:2142:0:b0:35d:a95f:d1e9 with SMTP id s2-20020a632142000000b0035da95fd1e9mr549335pgm.237.1645061153188; Wed, 16 Feb 2022 17:25:53 -0800 (PST) Received: from Laptop-X1 ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id d15sm44373635pfu.127.2022.02.16.17.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 17:25:52 -0800 (PST) Date: Thu, 17 Feb 2022 09:25:46 +0800 From: Hangbin Liu To: Eric Dumazet Cc: netdev@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S . Miller" , Jakub Kicinski , David Ahern , Nikolay Aleksandrov , Jonathan Toppins Subject: Re: [PATCH net-next 5/5] bonding: add new option ns_ip6_target Message-ID: References: <20220216080838.158054-1-liuhangbin@gmail.com> <20220216080838.158054-6-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 16, 2022 at 09:38:31AM -0800, Eric Dumazet wrote: > > On 2/16/22 00:08, Hangbin Liu wrote: > > This patch add a new bonding option ns_ip6_target, which correspond > > to the arp_ip_target. With this we set IPv6 targets and send IPv6 NS > > request to determine the health of the link. > > > > For other related options like the validation, we still use > > arp_validate, and will change to ns_validate later. > > > > Signed-off-by: Hangbin Liu > > --- > > Documentation/networking/bonding.rst | 11 +++ > > drivers/net/bonding/bond_netlink.c | 59 ++++++++++++ > > drivers/net/bonding/bond_options.c | 138 +++++++++++++++++++++++++++ > > drivers/net/bonding/bond_sysfs.c | 26 +++++ > > Thanks for the patches ! > > Do we really need to add sysfs parts, now rtnetlink is everywhere ? For Bonding I think yes. Bonding has disallowed to config via module_param. But there are still users using sysfs for bonding configuration. Jay, Veaceslav, please correct me if you think we can stop using sysfs. Thanks Hangbin