[PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties

[PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties

[Alexander Stein]

These properties are inherited from ethernet-controller.yaml.
This fixes the dt_binding_check warning:
imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index daa2f79a294f..73616924fa29 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -121,6 +121,10 @@ properties:
 
   mac-address: true
 
+  nvmem-cells: true
+
+  nvmem-cell-names: true
+
   tx-internal-delay-ps:
     enum: [0, 2000]
 
-- 
2.25.1

Re: [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties

[Rob Herring]

On Wed, Jan 26, 2022 at 03:47:48PM +0100, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..73616924fa29 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -121,6 +121,10 @@ properties:
>  
>    mac-address: true
>  
> +  nvmem-cells: true

Need to define how many.

> +
> +  nvmem-cell-names: true

And what the names are.

> +
>    tx-internal-delay-ps:
>      enum: [0, 2000]
>  
> -- 
> 2.25.1
> 
> 

Re: (EXT) Re: [PATCH 1/1] dt-bindings: net: fsl, fec: Add nvmem-cells / nvmem-cell-names properties

[Alexander Stein]

Hi Rob,

Am Mittwoch, 9. Februar 2022, 04:28:54 CET schrieb Rob Herring:
> On Wed, Jan 26, 2022 at 03:47:48PM +0100, Alexander Stein wrote:
> > These properties are inherited from ethernet-controller.yaml.
> > This fixes the dt_binding_check warning:
> > imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> > 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > b/Documentation/devicetree/bindings/net/fsl,fec.yaml index
> > daa2f79a294f..73616924fa29 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > 
> > @@ -121,6 +121,10 @@ properties:
> >    mac-address: true
> > 
> > +  nvmem-cells: true
> 
> Need to define how many.
> 
> > +
> > +  nvmem-cell-names: true
> 
> And what the names are.

Thanks for the feedback. Do I really have to copy the following lines from 
Documentation/devicetree/bindings/net/ethernet-controller.yaml to 
fsl,fec.yaml?

>   nvmem-cells:
>     maxItems: 1
>     
>     description:
>       Reference to an nvmem node for the MAC address
>   
>   nvmem-cell-names:
>     const: mac-address

This feels wrong to me. Apparently the settings from ethernet-controller.yaml 
take effect, e.g. adding a 2nd entry raises warnings. In the end I followed 
the example from Documentation/devicetree/bindings/net/engleder,tsnep.yaml, so 
I assumed it's okay going this way.

Best regards,
Alexander