Re: [PATCH net-next 0/1] [pull request] iwl-next Intel Wired LAN Driver Updates 2022-02-07

[Leon Romanovsky <leon@kernel.org>]

On Tue, Feb 08, 2022 at 09:18:36PM +0000, Nguyen, Anthony L wrote:
> On Tue, 2022-02-08 at 13:00 -0400, Jason Gunthorpe wrote:
> > On Mon, Feb 07, 2022 at 03:59:20PM -0800, Tony Nguyen wrote:
> > > This pull request is targeting net-next and rdma-next branches.
> > > RDMA
> > > patches will be sent to RDMA tree following acceptance of this
> > > shared
> > > pull request. These patches have been reviewed by netdev and RDMA
> > > mailing lists[1].
> > > 
> > > Dave adds support for ice driver to provide DSCP QoS mappings to
> > > irdma
> > > driver.
> > > 
> > > [1]
> > > https://lore.kernel.org/netdev/20220202191921.1638-1-shiraz.saleem@intel.com/
> > > The following are changes since commit
> > > e783362eb54cd99b2cac8b3a9aeac942e6f6ac07:
> > >   Linux 5.17-rc1
> > > and are available in the git repository at:
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/linux iwl-
> > > next
> > 
> > No signed tag?
> > 
> > In future can you send these in the standard form so patchworks will
> > pick them up?
> > 
> > Also please add cover letters so there is something to put in the
> > merge
> 
> I'm still trying to figure out how to do the shared pull requests. I'll
> look into resolving these issues you pointed out for next one.
> 
> One of the things I'm still unsure on is whether the shared pull
> request should contain the netdev and RDMA patches or only the netdev
> ones.

Shared PR intends to solve merge conflicts between various subsystems.

It means that sometimes both netdev and RDMA patches will be there,
however such situation is not common flow. Most of the time, you will
put only netdev changes there, because your driver core logic lays
there and it is there the conflicts will be.

However, there are minimal set of rules which you should follow:
1. This branch should be based on clean -rcX. No back merge of net-next
or rdma-next or other -next.
2. Bisectable
3. Possible to pull as a standlone set without extra patches on top
and it won't break compilation and/or working target which pulled this
branch.

Thanks

> 
> Thanks,
> Tony
> 
> > But PR applied along with the matching two RDMA patches.
> > Thanks,
> > Jason
>