From: Ido Schimmel <idosch@idosch.org>
To: Hans Schultz <schultz.hans@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Hans Schultz <schultz.hans+netdev@gmail.com>
Subject: Re: [PATCH net-next v2 0/5] Add support for locked bridge ports (for 802.1X)
Date: Wed, 9 Feb 2022 18:31:31 +0200 [thread overview]
Message-ID: <YgPsY6KrbDo2QHgX@shredder> (raw)
In-Reply-To: <20220209130538.533699-1-schultz.hans+netdev@gmail.com>
On Wed, Feb 09, 2022 at 02:05:32PM +0100, Hans Schultz wrote:
> This series starts by adding support for SA filtering to the bridge,
> which is then allowed to be offloaded to switchdev devices. Furthermore
> an offloading implementation is supplied for the mv88e6xxx driver.
[...]
> Hans Schultz (5):
> net: bridge: Add support for bridge port in locked mode
> net: bridge: Add support for offloading of locked port flag
> net: dsa: Add support for offloaded locked port flag
> net: dsa: mv88e6xxx: Add support for bridge port locked mode
> net: bridge: Refactor bridge port in locked mode to use jump labels
I think it is a bit weird to add a static key for this option when other
options (e.g., learning) don't use one. If you have data that proves
it's critical, then at least add it in patch #1 where the new option is
introduced.
Please add a selftest under tools/testing/selftests/net/forwarding/. It
should allow you to test both the SW data path with veth pairs and the
offloaded data path with loopbacks. See tools/testing/selftests/net/forwarding/README
next prev parent reply other threads:[~2022-02-09 16:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 13:05 [PATCH net-next v2 0/5] Add support for locked bridge ports (for 802.1X) Hans Schultz
2022-02-09 13:05 ` [PATCH net-next v2 1/5] net: bridge: Add support for bridge port in locked mode Hans Schultz
2022-02-10 8:30 ` Nikolay Aleksandrov
2022-02-10 10:20 ` Ido Schimmel
2022-02-09 13:05 ` [PATCH net-next v2 2/5] net: bridge: Add support for offloading of locked port flag Hans Schultz
2022-02-10 8:30 ` Nikolay Aleksandrov
2022-02-09 13:05 ` [PATCH net-next v2 3/5] net: dsa: Add support for offloaded " Hans Schultz
2022-02-10 17:09 ` Vladimir Oltean
2022-02-09 13:05 ` [PATCH net-next v2 4/5] net: dsa: mv88e6xxx: Add support for bridge port locked mode Hans Schultz
2022-02-09 13:05 ` [PATCH net-next v2 5/5] net: bridge: Refactor bridge port in locked mode to use jump labels Hans Schultz
2022-02-10 8:31 ` Nikolay Aleksandrov
2022-02-10 9:22 ` Hans Schultz
2022-02-09 16:31 ` Ido Schimmel [this message]
2022-02-10 9:07 ` [PATCH net-next v2 0/5] Add support for locked bridge ports (for 802.1X) Hans Schultz
2022-02-10 10:24 ` Ido Schimmel
2022-02-11 18:11 ` Florian Fainelli
2022-02-11 21:01 ` Vladimir Oltean
2022-02-13 18:44 ` Tobias Waldekranz
2022-02-11 22:59 ` Jakub Kicinski
2022-02-14 8:58 ` Hans Schultz
2022-02-14 16:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgPsY6KrbDo2QHgX@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schultz.hans+netdev@gmail.com \
--cc=schultz.hans@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).