From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Florian Westphal <fw@strlen.de>, Yi Chen <yiche@redhat.com>
Subject: Re: [PATCH nf] selftests: netfilter: disable rp_filter on router
Date: Thu, 10 Feb 2022 10:13:29 +0100 [thread overview]
Message-ID: <YgTXHziKmce/fzDY@salvia> (raw)
In-Reply-To: <YgTQ5KS1b2CZWvnR@Laptop-X1>
On Thu, Feb 10, 2022 at 04:46:28PM +0800, Hangbin Liu wrote:
> Hi Pablo, Florian,
> On Thu, Feb 10, 2022 at 11:32:05AM +0800, Hangbin Liu wrote:
> > +ip netns exec ${nsrouter} sysctl net.ipv4.conf.veth0.rp_filter=0 > /dev/null
> > +ip netns exec ${nsrouter} sysctl net.ipv4.conf.veth1.rp_filter=0 > /dev/null
>
> Oh, disable rp_filter on veth0 is enough for the current testing. But for the
> format and maybe a preparation for future testing. Disable veth1 rp_filter
> should also be OK. If you think there is no need to do this on veth1.
> I can send a v2 patch.
Send v2, I'll toss v1 patch.
Thanks.
next prev parent reply other threads:[~2022-02-10 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 3:32 [PATCH nf] selftests: netfilter: disable rp_filter on router Hangbin Liu
2022-02-10 8:46 ` Hangbin Liu
2022-02-10 9:13 ` Pablo Neira Ayuso [this message]
2022-02-10 8:56 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgTXHziKmce/fzDY@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yiche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).