Netdev List
 help / color / mirror / Atom feed
From: Harald Welte <laforge@osmocom.org>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: Marcin Szycik <marcin.szycik@linux.intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"michal.swiatkowski@linux.intel.com" 
	<michal.swiatkowski@linux.intel.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pablo@netfilter.org" <pablo@netfilter.org>,
	"osmocom-net-gprs@lists.osmocom.org" 
	<osmocom-net-gprs@lists.osmocom.org>
Subject: Re: [RFC PATCH net-next v4 4/6] gtp: Implement GTP echo response
Date: Fri, 11 Feb 2022 10:16:23 +0100	[thread overview]
Message-ID: <YgYpZzOo3FQG+SY2@nataraja> (raw)
In-Reply-To: <MW4PR11MB5776D18B1DA527575987CB1DFD2D9@MW4PR11MB5776.namprd11.prod.outlook.com>

Hi Wojciech,

On Tue, Feb 08, 2022 at 02:12:33PM +0000, Drewek, Wojciech wrote:
> > Remember, GTP-U uses different IP addresses and also typically completely
> > different hosts/systems, so having GTP-C connectivity between two GSN
> > doesn't say anything about the GTP-U path.
>
> Two  approaches come to mind.
> The first one assumes that peers are stored in kernel as PDP contexts in
> gtp_dev (tid_hash and addr_hash). Then we could enable a watchdog
> that could in regular intervals (defined by the user) send echo requests
> to all peers.

Interesting proposal.  However, it raises the next question of what to do if
the path is deemed to be lost (N out of M recent echo requests unanswered)? It
would have to notify the userspace daemon (control plane) via a netlink event
or the like.  So at that point you need to implement some special processing in
that userspace daemon...

> In the second one user could trigger echo request from userspace
> (using new genl cmd) at any time. However this approach would require that
> some userspace daemon would implement triggering this command.

I think this is the better approach.  It keeps a lot of logic like timeouts,
frequency of transmission, determining when a path is considered dead, ... out
of the kernel, where it doesn't need to be.

> What do you think?

As both approaches require some support from the userspace control plane instance,
I would argue that the second proposal is superior.

Regards,
	Harald

-- 
- Harald Welte <laforge@osmocom.org>            http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

  reply	other threads:[~2022-02-11  9:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 16:49 [RFC PATCH net-next v4 0/6] ice: GTP support in switchdev Marcin Szycik
2022-02-04 16:50 ` [RFC PATCH net-next v4 1/6] gtp: Allow to create GTP device without FDs Marcin Szycik
2022-02-04 16:50 ` [RFC PATCH net-next v4 2/6] gtp: Add support for checking GTP device type Marcin Szycik
2022-02-04 16:50 ` [RFC PATCH net-next v4 3/6] net/sched: Allow flower to match on GTP options Marcin Szycik
2022-02-04 16:51 ` [RFC PATCH net-next v4 4/6] gtp: Implement GTP echo response Marcin Szycik
2022-02-05 16:51   ` Harald Welte
2022-02-08 14:12     ` Drewek, Wojciech
2022-02-11  9:16       ` Harald Welte [this message]
2022-02-11 10:27         ` Drewek, Wojciech
2022-02-11 12:48           ` Drewek, Wojciech
2022-02-12 11:05             ` Harald Welte
2022-02-04 16:51 ` [RFC PATCH net-next v4 5/6] ice: Fix FV offset searching Marcin Szycik
2022-02-04 16:51 ` [RFC PATCH net-next v4 6/6] ice: Support GTP-U and GTP-C offload in switchdev Marcin Szycik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgYpZzOo3FQG+SY2@nataraja \
    --to=laforge@osmocom.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=marcin.szycik@linux.intel.com \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=osmocom-net-gprs@lists.osmocom.org \
    --cc=pablo@netfilter.org \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox