From: Rob Herring <robh@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Li Yang <leoyang.li@nxp.com>, Michael Walle <michael@walle.cc>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" compatible to sl28cpld
Date: Fri, 11 Feb 2022 07:01:42 -0600 [thread overview]
Message-ID: <YgZeNqAbdisyeT+s@robh.at.kernel.org> (raw)
In-Reply-To: <20220127172105.4085950-3-vladimir.oltean@nxp.com>
On Thu, Jan 27, 2022 at 07:21:04PM +0200, Vladimir Oltean wrote:
> The LS1028A-QDS QIXIS FPGA has no problem working with the
> simple-mfd-i2c.c driver, so extend the list of compatible strings to
> include that part.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml
> index eb3b43547cb6..8c1216eb36ee 100644
> --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml
> +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml
> @@ -16,7 +16,9 @@ description: |
>
> properties:
> compatible:
> - const: kontron,sl28cpld
> + enum:
> + - fsl,ls1028a-qds-qixis-i2c
> + - kontron,sl28cpld
Is there some relationship between these besides happening to use the
same driver? Sharing a generic driver is not a reason to have the same
binding doc.
Your DT has a mux-controller which is undocuemnted in this binding.
Rob
next prev parent reply other threads:[~2022-02-11 13:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 17:21 [PATCH 0/3] Use sl28cpld driver for the LS1028A-QDS QIXIS FPGA Vladimir Oltean
2022-01-27 17:21 ` [PATCH 1/3] mfd: simple-mfd-i2c: add compatible string for LS1028A-QDS FPGA Vladimir Oltean
2022-01-28 8:44 ` Lee Jones
2022-01-27 17:21 ` [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" compatible to sl28cpld Vladimir Oltean
2022-02-11 13:01 ` Rob Herring [this message]
2022-02-11 13:24 ` Vladimir Oltean
2022-02-11 13:29 ` Michael Walle
2022-01-27 17:21 ` [PATCH 3/3] arm64: dts: ls1028a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c driver Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgZeNqAbdisyeT+s@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=lee.jones@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).