netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next V1 5/5] net: lan743x: Add support for Clause-45 MDIO PHY management
Date: Sat, 12 Feb 2022 20:53:57 +0100	[thread overview]
Message-ID: <YggQVTZJhmEh0YQk@lunn.ch> (raw)
In-Reply-To: <20220212155315.340359-6-Raju.Lakkaraju@microchip.com>

> +static int lan743x_mdiobus_c45_read(struct mii_bus *bus, int phy_id, int index)
> +{
> +	if (index & MII_ADDR_C45) {

...

> +		return (int)(ret & 0xFFFF);
> +	}
> +
> +	ret = lan743x_mdiobus_read(bus, phy_id, index);
> +	return ret;

This function appear to either do a c45 or a c22 access. So the
function name is not very accurate.

	 Andrew

  reply	other threads:[~2022-02-12 19:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-12 15:53 [PATCH net-next V1 0/5] net: lan743x: PCI11010 / PCI11414 devices Enhancements Raju Lakkaraju
2022-02-12 15:53 ` [PATCH net-next V1 1/5] net: lan743x: Add PCI11010 / PCI11414 device IDs Raju Lakkaraju
2022-02-12 15:53 ` [PATCH net-next V1 2/5] net: lan743x: Add support for 4 Tx queues Raju Lakkaraju
2022-02-12 15:53 ` [PATCH net-next V1 3/5] net: lan743x: Increase MSI(x) vectors to 16 and Int de-assertion timers to 10 Raju Lakkaraju
2022-02-12 15:53 ` [PATCH net-next V1 4/5] net: lan743x: Add support for SGMII interface Raju Lakkaraju
2022-02-12 15:53 ` [PATCH net-next V1 5/5] net: lan743x: Add support for Clause-45 MDIO PHY management Raju Lakkaraju
2022-02-12 19:53   ` Andrew Lunn [this message]
2022-02-13 12:20 ` [PATCH net-next V1 0/5] net: lan743x: PCI11010 / PCI11414 devices Enhancements patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YggQVTZJhmEh0YQk@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Raju.Lakkaraju@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).